From ba4e9e6e47bd10ecc803bab920178ea973c2fa86 Mon Sep 17 00:00:00 2001 From: Emma Foley Date: Wed, 29 Nov 2017 22:56:21 +0000 Subject: Move tests: unit/benchmark * Fix pylint errors * Add TODOs Some errors are ignored locally, as they were a symptom of other problems. These issues have been flagged with a TODO, and should be fixed later. Change-Id: I30eb4b0aafe0575d0cddbc946108291f21a98ed8 Jira: YARDSTICK-837 Signed-off-by: Emma Foley Signed-off-by: Ross Brattain --- tests/unit/benchmark/core/test_task.py | 314 --------------------------------- 1 file changed, 314 deletions(-) delete mode 100644 tests/unit/benchmark/core/test_task.py (limited to 'tests/unit/benchmark/core/test_task.py') diff --git a/tests/unit/benchmark/core/test_task.py b/tests/unit/benchmark/core/test_task.py deleted file mode 100644 index bed0bb6d8..000000000 --- a/tests/unit/benchmark/core/test_task.py +++ /dev/null @@ -1,314 +0,0 @@ -#!/usr/bin/env python - -############################################################################## -# Copyright (c) 2015 Huawei Technologies Co.,Ltd and others. -# -# All rights reserved. This program and the accompanying materials -# are made available under the terms of the Apache License, Version 2.0 -# which accompanies this distribution, and is available at -# http://www.apache.org/licenses/LICENSE-2.0 -############################################################################## - -# Unittest for yardstick.benchmark.core.task - -from __future__ import print_function - -from __future__ import absolute_import -import os -import unittest - -try: - from unittest import mock -except ImportError: - import mock - - -from yardstick.benchmark.core import task -from yardstick.common import constants as consts - - -class TaskTestCase(unittest.TestCase): - - @mock.patch('yardstick.benchmark.core.task.Context') - def test_parse_nodes_host_target_same_context(self, mock_context): - nodes = { - "host": "node1.LF", - "target": "node2.LF" - } - scenario_cfg = {"nodes": nodes} - server_info = { - "ip": "10.20.0.3", - "user": "root", - "key_filename": "/root/.ssh/id_rsa" - } - mock_context.get_server.return_value = server_info - context_cfg = task.parse_nodes_with_context(scenario_cfg) - - self.assertEqual(context_cfg["host"], server_info) - self.assertEqual(context_cfg["target"], server_info) - - def test_set_dispatchers(self): - t = task.Task() - output_config = {"DEFAULT": {"dispatcher": "file, http"}} - t._set_dispatchers(output_config) - self.assertEqual(output_config, output_config) - - @mock.patch('yardstick.benchmark.core.task.DispatcherBase') - def test__do_output(self, mock_dispatcher): - t = task.Task() - output_config = {"DEFAULT": {"dispatcher": "file, http"}} - mock_dispatcher.get = mock.MagicMock(return_value=[mock.MagicMock(), - mock.MagicMock()]) - self.assertEqual(None, t._do_output(output_config, {})) - - @mock.patch('yardstick.benchmark.core.task.Context') - def test_parse_networks_from_nodes(self, mock_context): - nodes = { - 'node1': { - 'interfaces': { - 'mgmt': { - 'network_name': 'mgmt', - }, - 'xe0': { - 'network_name': 'uplink_0', - }, - 'xe1': { - 'network_name': 'downlink_0', - }, - }, - }, - 'node2': { - 'interfaces': { - 'mgmt': { - 'network_name': 'mgmt', - }, - 'uplink_0': { - 'network_name': 'uplink_0', - }, - 'downlink_0': { - 'network_name': 'downlink_0', - }, - }, - }, - } - - mock_context.get_network.side_effect = iter([ - None, - { - 'name': 'mgmt', - 'network_type': 'flat', - }, - {}, - { - 'name': 'uplink_0', - 'subnet_cidr': '10.20.0.0/16', - }, - { - 'name': 'downlink_0', - 'segmentation_id': '1001', - }, - { - 'name': 'uplink_1', - }, - ]) - - # one for each interface - expected_get_network_calls = 6 - expected = { - 'mgmt': {'name': 'mgmt', 'network_type': 'flat'}, - 'uplink_0': {'name': 'uplink_0', 'subnet_cidr': '10.20.0.0/16'}, - 'uplink_1': {'name': 'uplink_1'}, - 'downlink_0': {'name': 'downlink_0', 'segmentation_id': '1001'}, - } - - networks = task.get_networks_from_nodes(nodes) - self.assertEqual(mock_context.get_network.call_count, expected_get_network_calls) - self.assertDictEqual(networks, expected) - - @mock.patch('yardstick.benchmark.core.task.Context') - @mock.patch('yardstick.benchmark.core.task.base_runner') - def test_run(self, mock_base_runner, mock_ctx): - scenario = { - 'host': 'athena.demo', - 'target': 'ares.demo', - 'runner': { - 'duration': 60, - 'interval': 1, - 'type': 'Duration' - }, - 'type': 'Ping' - } - - t = task.Task() - runner = mock.Mock() - runner.join.return_value = 0 - runner.get_output.return_value = {} - runner.get_result.return_value = [] - mock_base_runner.Runner.get.return_value = runner - t._run([scenario], False, "yardstick.out") - self.assertTrue(runner.run.called) - - @mock.patch('yardstick.benchmark.core.task.os') - def test_check_precondition(self, mock_os): - cfg = { - 'precondition': { - 'installer_type': 'compass', - 'deploy_scenarios': 'os-nosdn', - 'pod_name': 'huawei-pod1' - } - } - - t = task.TaskParser('/opt') - mock_os.environ.get.side_effect = ['compass', - 'os-nosdn', - 'huawei-pod1'] - result = t._check_precondition(cfg) - self.assertTrue(result) - - def test_parse_suite_no_constraint_no_args(self): - SAMPLE_SCENARIO_PATH = "no_constraint_no_args_scenario_sample.yaml" - t = task.TaskParser(self._get_file_abspath(SAMPLE_SCENARIO_PATH)) - with mock.patch('yardstick.benchmark.core.task.os.environ', - new={'NODE_NAME': 'huawei-pod1', 'INSTALLER_TYPE': 'compass'}): - task_files, task_args, task_args_fnames = t.parse_suite() - print("files=%s, args=%s, fnames=%s" % (task_files, task_args, - task_args_fnames)) - self.assertEqual(task_files[0], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc037.yaml')) - self.assertEqual(task_files[1], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc043.yaml')) - self.assertEqual(task_args[0], None) - self.assertEqual(task_args[1], None) - self.assertEqual(task_args_fnames[0], None) - self.assertEqual(task_args_fnames[1], None) - - @mock.patch('yardstick.benchmark.core.task.os.environ') - def test_parse_suite_no_constraint_with_args(self, mock_environ): - SAMPLE_SCENARIO_PATH = "no_constraint_with_args_scenario_sample.yaml" - t = task.TaskParser(self._get_file_abspath(SAMPLE_SCENARIO_PATH)) - with mock.patch('yardstick.benchmark.core.task.os.environ', - new={'NODE_NAME': 'huawei-pod1', 'INSTALLER_TYPE': 'compass'}): - task_files, task_args, task_args_fnames = t.parse_suite() - print("files=%s, args=%s, fnames=%s" % (task_files, task_args, - task_args_fnames)) - self.assertEqual(task_files[0], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc037.yaml')) - self.assertEqual(task_files[1], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc043.yaml')) - self.assertEqual(task_args[0], None) - self.assertEqual(task_args[1], - '{"host": "node1.LF","target": "node2.LF"}') - self.assertEqual(task_args_fnames[0], None) - self.assertEqual(task_args_fnames[1], None) - - @mock.patch('yardstick.benchmark.core.task.os.environ') - def test_parse_suite_with_constraint_no_args(self, mock_environ): - SAMPLE_SCENARIO_PATH = "with_constraint_no_args_scenario_sample.yaml" - t = task.TaskParser(self._get_file_abspath(SAMPLE_SCENARIO_PATH)) - with mock.patch('yardstick.benchmark.core.task.os.environ', - new={'NODE_NAME': 'huawei-pod1', 'INSTALLER_TYPE': 'compass'}): - task_files, task_args, task_args_fnames = t.parse_suite() - print("files=%s, args=%s, fnames=%s" % (task_files, task_args, - task_args_fnames)) - self.assertEqual(task_files[0], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc037.yaml')) - self.assertEqual(task_files[1], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc043.yaml')) - self.assertEqual(task_args[0], None) - self.assertEqual(task_args[1], None) - self.assertEqual(task_args_fnames[0], None) - self.assertEqual(task_args_fnames[1], None) - - @mock.patch('yardstick.benchmark.core.task.os.environ') - def test_parse_suite_with_constraint_with_args(self, mock_environ): - SAMPLE_SCENARIO_PATH = "with_constraint_with_args_scenario_sample.yaml" - t = task.TaskParser(self._get_file_abspath(SAMPLE_SCENARIO_PATH)) - with mock.patch('yardstick.benchmark.core.task.os.environ', - new={'NODE_NAME': 'huawei-pod1', 'INSTALLER_TYPE': 'compass'}): - task_files, task_args, task_args_fnames = t.parse_suite() - print("files=%s, args=%s, fnames=%s" % (task_files, task_args, - task_args_fnames)) - self.assertEqual(task_files[0], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc037.yaml')) - self.assertEqual(task_files[1], self.change_to_abspath( - 'tests/opnfv/test_cases/opnfv_yardstick_tc043.yaml')) - self.assertEqual(task_args[0], None) - self.assertEqual(task_args[1], - '{"host": "node1.LF","target": "node2.LF"}') - self.assertEqual(task_args_fnames[0], None) - self.assertEqual(task_args_fnames[1], None) - - def test_parse_options(self): - options = { - 'openstack': { - 'EXTERNAL_NETWORK': '$network' - }, - 'ndoes': ['node1', '$node'], - 'host': '$host' - } - - t = task.Task() - t.outputs = { - 'network': 'ext-net', - 'node': 'node2', - 'host': 'server.yardstick' - } - - idle_result = { - 'openstack': { - 'EXTERNAL_NETWORK': 'ext-net' - }, - 'ndoes': ['node1', 'node2'], - 'host': 'server.yardstick' - } - - actual_result = t._parse_options(options) - self.assertEqual(idle_result, actual_result) - - def test_change_server_name_host_str(self): - scenario = {'host': 'demo'} - suffix = '-8' - task.change_server_name(scenario, suffix) - self.assertTrue(scenario['host'], 'demo-8') - - def test_change_server_name_host_dict(self): - scenario = {'host': {'name': 'demo'}} - suffix = '-8' - task.change_server_name(scenario, suffix) - self.assertTrue(scenario['host']['name'], 'demo-8') - - def test_change_server_name_target_str(self): - scenario = {'target': 'demo'} - suffix = '-8' - task.change_server_name(scenario, suffix) - self.assertTrue(scenario['target'], 'demo-8') - - def test_change_server_name_target_dict(self): - scenario = {'target': {'name': 'demo'}} - suffix = '-8' - task.change_server_name(scenario, suffix) - self.assertTrue(scenario['target']['name'], 'demo-8') - - @mock.patch('yardstick.benchmark.core.task.utils') - @mock.patch('yardstick.benchmark.core.task.logging') - def test_set_log(self, mock_logging, mock_utils): - task_obj = task.Task() - task_obj.task_id = 'task_id' - task_obj._set_log() - self.assertTrue(mock_logging.root.addHandler.called) - - def _get_file_abspath(self, filename): - curr_path = os.path.dirname(os.path.abspath(__file__)) - file_path = os.path.join(curr_path, filename) - return file_path - - def change_to_abspath(self, filepath): - return os.path.join(consts.YARDSTICK_ROOT_PATH, filepath) - - -def main(): - unittest.main() - - -if __name__ == '__main__': - main() -- cgit 1.2.3-korg