From ca9c9275ed6d5d852987c69a378e88a3502cb2ab Mon Sep 17 00:00:00 2001 From: goldammx Date: Thu, 9 Feb 2017 08:03:00 -0500 Subject: pylint: Fixing pylint errors and warnings All python files must reach pylint score 10/10. This will be regularly verified by Jenkins jobs to keep constant code quality. VSPERF specific pylintrc file was updated according to the vsperf coding standards. Distro version included in reports will be slightly different, due to migration to new python package distro. Previously used platform.distro() will be deprecated since python 3.7. JIRA: VSPERF-487 Change-Id: I934120208b9624787a3567ccaa49e14d77d7a5bf Signed-off-by: Martin Goldammer Reviewed-by: Martin Klozik Reviewed-by: Al Morton Reviewed-by: Christian Trautman Reviewed-by: Bill Michalowski Reviewed-by: Antonio Fischetti Reviewed-by: Sridhar Rao --- core/vnf_controller.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'core/vnf_controller.py') diff --git a/core/vnf_controller.py b/core/vnf_controller.py index 937cd5cc..78a29258 100644 --- a/core/vnf_controller.py +++ b/core/vnf_controller.py @@ -1,4 +1,4 @@ -# Copyright 2015-2016 Intel Corporation. +# Copyright 2015-2017 Intel Corporation. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -67,10 +67,10 @@ class VnfController(object): # enforce that GUEST_NIC_NR is 1 or even number of NICs updated = False nics_nr = settings.getValue('GUEST_NICS_NR') - for index in range(len(nics_nr)): - if nics_nr[index] > 1 and nics_nr[index] % 2: + for index, value in enumerate(nics_nr): + if value > 1 and value % 2: updated = True - nics_nr[index] = int(nics_nr[index] / 2) * 2 + nics_nr[index] = int(value / 2) * 2 if updated: settings.setValue('GUEST_NICS_NR', nics_nr) self._logger.warning('Odd number of NICs was detected. Configuration ' -- cgit 1.2.3-korg