From 7c3bbf62df8553475b787ffd234cd3df3fa0c90b Mon Sep 17 00:00:00 2001 From: spisarski Date: Fri, 21 Jul 2017 08:08:30 -0600 Subject: Created new class ProjectSettingsError. Raising ProjectSettingsError in ProjectSettings instead of Exception. JIRA: SNAPS-135 Change-Id: I5169dd196775453466ea8d7fe9fa0c8d82b2382a Signed-off-by: spisarski --- snaps/openstack/create_project.py | 8 +++++++- snaps/openstack/tests/create_project_tests.py | 7 ++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/snaps/openstack/create_project.py b/snaps/openstack/create_project.py index 0384ccc..a20033e 100644 --- a/snaps/openstack/create_project.py +++ b/snaps/openstack/create_project.py @@ -131,5 +131,11 @@ class ProjectSettings: self.enabled = True if not self.name: - raise Exception( + raise ProjectSettingsError( "The attribute name is required for ProjectSettings") + + +class ProjectSettingsError(Exception): + """ + Exception to be thrown when project settings attributes are incorrect + """ diff --git a/snaps/openstack/tests/create_project_tests.py b/snaps/openstack/tests/create_project_tests.py index 3c6b2d1..f2af0d9 100644 --- a/snaps/openstack/tests/create_project_tests.py +++ b/snaps/openstack/tests/create_project_tests.py @@ -15,7 +15,8 @@ import unittest import uuid -from snaps.openstack.create_project import OpenStackProject, ProjectSettings +from snaps.openstack.create_project import ( + OpenStackProject, ProjectSettings, ProjectSettingsError) from snaps.openstack.create_security_group import OpenStackSecurityGroup from snaps.openstack.create_security_group import SecurityGroupSettings from snaps.openstack.create_user import OpenStackUser @@ -32,11 +33,11 @@ class ProjectSettingsUnitTests(unittest.TestCase): """ def test_no_params(self): - with self.assertRaises(Exception): + with self.assertRaises(ProjectSettingsError): ProjectSettings() def test_empty_config(self): - with self.assertRaises(Exception): + with self.assertRaises(ProjectSettingsError): ProjectSettings(**dict()) def test_name_only(self): -- cgit 1.2.3-korg