diff options
author | spisarski <s.pisarski@cablelabs.com> | 2017-07-21 08:18:11 -0600 |
---|---|---|
committer | spisarski <s.pisarski@cablelabs.com> | 2017-07-21 10:13:19 -0600 |
commit | 8eb8d2fa3490aaae111717f445300eac8b3e6ed4 (patch) | |
tree | de83c66bd105ca8453c49737b836f7a028bf76bd /snaps/openstack/tests/create_router_tests.py | |
parent | b0af6e93bb5cc338c289577aad5c4b1bf8de7053 (diff) |
Created new classes RouterSettingsError & RouterCreationError.
Raising RouterSettingsError in RouterSettings and RouterCreationError in
OpenStackRouter instead of Exception.
JIRA: SNAPS-136
Change-Id: I3ba4824ea80ccfc07b1f15959898936d51bca1de
Signed-off-by: spisarski <s.pisarski@cablelabs.com>
Diffstat (limited to 'snaps/openstack/tests/create_router_tests.py')
-rw-r--r-- | snaps/openstack/tests/create_router_tests.py | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/snaps/openstack/tests/create_router_tests.py b/snaps/openstack/tests/create_router_tests.py index 5f2534d..efa0993 100644 --- a/snaps/openstack/tests/create_router_tests.py +++ b/snaps/openstack/tests/create_router_tests.py @@ -1,4 +1,4 @@ -# Copyright (c) 2016 Cable Television Laboratories, Inc. ("CableLabs") +# Copyright (c) 2017 Cable Television Laboratories, Inc. ("CableLabs") # and others. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); @@ -20,7 +20,8 @@ from snaps.openstack import create_router from snaps.openstack.create_network import ( NetworkSettings, PortSettings) from snaps.openstack.create_network import OpenStackNetwork -from snaps.openstack.create_router import RouterSettings +from snaps.openstack.create_router import ( + RouterSettings, RouterSettingsError, RouterCreationError) from snaps.openstack.tests.os_source_file_test import OSIntegrationTestCase from snaps.openstack.utils import neutron_utils @@ -38,11 +39,11 @@ class RouterSettingsUnitTests(unittest.TestCase): """ def test_no_params(self): - with self.assertRaises(Exception): + with self.assertRaises(RouterSettingsError): RouterSettings() def test_empty_config(self): - with self.assertRaises(Exception): + with self.assertRaises(RouterSettingsError): RouterSettings(**dict()) def test_name_only(self): @@ -338,7 +339,7 @@ class CreateRouterNegativeTests(OSIntegrationTestCase): """ Test creating a router without a name. """ - with self.assertRaises(Exception): + with self.assertRaises(RouterSettingsError): router_settings = RouterSettings( name=None, external_gateway=self.ext_net_name) self.router_creator = create_router.OpenStackRouter( @@ -349,7 +350,7 @@ class CreateRouterNegativeTests(OSIntegrationTestCase): """ Test creating a router without a valid network gateway name. """ - with self.assertRaises(Exception): + with self.assertRaises(RouterSettingsError): router_settings = RouterSettings(name=self.guid + '-pub-router', external_gateway="Invalid_name") self.router_creator = create_router.OpenStackRouter( |