summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Pisarski <s.pisarski@cablelabs.com>2017-07-31 13:53:46 +0000
committerGerrit Code Review <gerrit@opnfv.org>2017-07-31 13:53:46 +0000
commitb003647b70545008405294c4268e62fa87c18574 (patch)
treec542675cbf06bb7d331f8069c839489369f4d59b
parent84c4e791b6ea4e6d488acf29491ef8c901011aa3 (diff)
parent9faae5becd270c6f98bff1079754dac2ee2fb76d (diff)
Merge "Remove TODOs from create_router.py"
-rw-r--r--snaps/openstack/create_router.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/snaps/openstack/create_router.py b/snaps/openstack/create_router.py
index acf6602..335be2c 100644
--- a/snaps/openstack/create_router.py
+++ b/snaps/openstack/create_router.py
@@ -81,8 +81,9 @@ class OpenStackRouter:
self.__internal_subnets.append(internal_subnet)
if internal_subnet and not cleanup and not existing:
logger.debug('Adding router to subnet...')
- self.__internal_router_interface = neutron_utils.add_interface_router(
+ router_intf = neutron_utils.add_interface_router(
self.__neutron, self.__router, subnet=internal_subnet)
+ self.__internal_router_interface = router_intf
else:
raise RouterCreationError(
'Subnet not found with name ' + internal_subnet_name)
@@ -262,9 +263,6 @@ class RouterSettings:
'Could not find the external network named - ' +
self.external_gateway)
- # TODO: Enable SNAT option for Router
- # TODO: Add external_fixed_ips Tests
-
return {'router': out}