From 3e0ba9638fd98d43f3b2f632351c2edb556d03af Mon Sep 17 00:00:00 2001 From: Venkata Harshavardhan Reddy Allu Date: Mon, 25 Jun 2018 16:01:00 +0530 Subject: Remove side_effect method in 'test_cleanup.py' module The side_effect method under test_delete_openstack_objects_exception method in 'test_cleanup.py' module is not needed. In fact, it won't be called at all. It should have been detected in [pylint] W0612. So when we run the nosetest, side_effect from Mock instances of mock_creator_obj_one and mock_creator_obj_two were called. Change-Id: Ibad6c8ebe14c320ef31c2133635ecd45fd011835 Signed-off-by: Venkata Harshavardhan Reddy Allu --- sfc/unit_tests/unit/lib/test_cleanup.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/sfc/unit_tests/unit/lib/test_cleanup.py b/sfc/unit_tests/unit/lib/test_cleanup.py index 34e5a56b..5ec4261e 100644 --- a/sfc/unit_tests/unit/lib/test_cleanup.py +++ b/sfc/unit_tests/unit/lib/test_cleanup.py @@ -269,8 +269,6 @@ class SfcCleanupTesting(unittest.TestCase): Check the proper functionality of the delete_openstack_objects function when exception occurs. """ - def side_effect(): - raise Exception('First Boom!') mock_creator_obj_one = Mock() mock_creator_obj_two = Mock() -- cgit 1.2.3-korg