From 06ed156d9a9eb6cf8f61e7a7b3d9d35f30e6d755 Mon Sep 17 00:00:00 2001 From: Venkata Harshavardhan Reddy Allu Date: Fri, 22 Mar 2019 17:58:00 +0530 Subject: Add pylint check to tox Pylint is necessary to avoid potential errors which flake8 doesn't detect because flake8 is concentrated on code style rather than linting. Change-Id: I50f455227e85c08465e312e07b276698b502cdd2 Signed-off-by: Venkata Harshavardhan Reddy Allu --- test-requirements.txt | 1 + tox.ini | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/test-requirements.txt b/test-requirements.txt index a504b51b..363f51dd 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -5,3 +5,4 @@ coverage!=4.4 # Apache-2.0 mock # BSD nose # LGPL yamllint +pylint diff --git a/tox.ini b/tox.ini index a92fccf2..c359c547 100644 --- a/tox.ini +++ b/tox.ini @@ -1,5 +1,5 @@ [tox] -envlist = docs,docs-linkcheck,py27,yamllint +envlist = docs,docs-linkcheck,py27,yamllint,pylint skipsdist = True [testenv] @@ -41,3 +41,18 @@ files = sfc/tests/functest commands = yamllint -s {[testenv:yamllint]files} + +[testenv:pylint] +basepython = python2.7 +commands = pylint --rcfile=tox.ini sfc + +# pylintrc +[MESSAGES CONTROL] +disable=all + +enable=F,E,unreachable,duplicate-key,unnecessary-semicolon, + global-variable-not-assigned,unused-variable,binary-op-exception, + bad-format-string,anomalous-backslash-in-string,bad-open-mode + +[TYPECHECK] +ignored-classes=Connection -- cgit 1.2.3-korg