From 18443e7872ddb154e2c91433ed03b09deab90321 Mon Sep 17 00:00:00 2001 From: tomsou Date: Tue, 27 Jun 2017 13:51:13 +0000 Subject: Adapt the floating ip handling in functest Comply with the new floating ip management in functest (https://gerrit.opnfv.org/gerrit/#/c/36415) JIRA: SDNVPN-165 Change-Id: I39e380caf07568e2370246afcf483eb8adb3def6 Signed-off-by: tomsou --- sdnvpn/lib/utils.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) (limited to 'sdnvpn/lib/utils.py') diff --git a/sdnvpn/lib/utils.py b/sdnvpn/lib/utils.py index 7e41d41..220f61e 100644 --- a/sdnvpn/lib/utils.py +++ b/sdnvpn/lib/utils.py @@ -538,8 +538,16 @@ def detach_instance_from_ext_br(instance, compute_node): compute_node.run_cmd(cmd.format(bridge=bridge)) -def cleanup_neutron(neutron_client, bgpvpn_ids, interfaces, subnet_ids, - router_ids, network_ids): +def cleanup_neutron(neutron_client, floatingip_ids, bgpvpn_ids, interfaces, + subnet_ids, router_ids, network_ids): + + if len(floatingip_ids) != 0: + for floatingip_id in floatingip_ids: + if not os_utils.delete_floating_ip(neutron_client, floatingip_id): + logging.error('Fail to delete all floating ips. ' + 'Floating ip with id {} was not deleted.'. + format(floatingip_id)) + return False if len(bgpvpn_ids) != 0: for bgpvpn_id in bgpvpn_ids: @@ -586,16 +594,7 @@ def cleanup_neutron(neutron_client, bgpvpn_ids, interfaces, subnet_ids, return True -def cleanup_nova(nova_client, floatingip_ids, instance_ids, image_ids): - - if len(floatingip_ids) != 0: - for floatingip_id in floatingip_ids: - if not os_utils.delete_floating_ip(nova_client, floatingip_id): - logging.error('Fail to delete all floating ips. ' - 'Floating ip with id {} was not deleted.'. - format(floatingip_id)) - return False - +def cleanup_nova(nova_client, instance_ids, image_ids): if len(instance_ids) != 0: for instance_id in instance_ids: if not os_utils.delete_instance(nova_client, instance_id): -- cgit 1.2.3-korg