From 2b9009385839d6dc33beabd4eb833b179d4693f4 Mon Sep 17 00:00:00 2001 From: Alexandru Avadanii Date: Mon, 24 Sep 2018 17:13:00 +0200 Subject: macros, docs, releng: Use `sudo -H` pip install This is still far from a clean and secure approach, as `pip install` should not be ran with `sudo`. However, `-H` limits the area we touch and also fixes some incompat between disto-provided pip and pip-provided pip. Change-Id: I0e19dfeaf66f6f453e3868c71016305ae050f0c8 Signed-off-by: Alexandru Avadanii --- jjb/global/releng-macros.yaml | 4 ++-- jjb/opnfvdocs/docs-rtd.yaml | 2 +- jjb/releng/releng-release-create-venv.sh | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'jjb') diff --git a/jjb/global/releng-macros.yaml b/jjb/global/releng-macros.yaml index 8055fdbdf..fe24ed56d 100644 --- a/jjb/global/releng-macros.yaml +++ b/jjb/global/releng-macros.yaml @@ -420,7 +420,7 @@ - shell: | #!/bin/bash # Install python package - sudo pip install "flake8==2.6.2" + sudo -H pip install "flake8==2.6.2" echo "Checking python code..." for f in $(egrep '\.py$' modified_files) @@ -438,7 +438,7 @@ - shell: | #!/bin/bash # sudo Install python packages - sudo pip install "yamllint==1.8.2" + sudo -H pip install "yamllint==1.8.2" echo "Checking yaml file..." for f in $(egrep '\.ya?ml$' modified_files) diff --git a/jjb/opnfvdocs/docs-rtd.yaml b/jjb/opnfvdocs/docs-rtd.yaml index ece856903..fc99bd392 100644 --- a/jjb/opnfvdocs/docs-rtd.yaml +++ b/jjb/opnfvdocs/docs-rtd.yaml @@ -88,7 +88,7 @@ git fetch origin $GERRIT_REFSPEC && git checkout FETCH_HEAD fi - shell: | - sudo pip install virtualenv + sudo -H pip install virtualenv virtualenv $WORKSPACE/venv . $WORKSPACE/venv/bin/activate pip install --upgrade pip diff --git a/jjb/releng/releng-release-create-venv.sh b/jjb/releng/releng-release-create-venv.sh index 0d5635b59..de585fdb3 100644 --- a/jjb/releng/releng-release-create-venv.sh +++ b/jjb/releng/releng-release-create-venv.sh @@ -10,7 +10,7 @@ set -e -o pipefail echo "---> Create virtualenv" -sudo pip install virtualenv +sudo -H pip install virtualenv virtualenv $WORKSPACE/venv # shellcheck source=$WORKSPACE/venv/bin/activate disable=SC1091 source $WORKSPACE/venv/bin/activate -- cgit 1.2.3-korg