summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFatih Degirmenci <fdegir@gmail.com>2019-09-03 09:30:50 +0000
committerGerrit Code Review <gerrit@opnfv.org>2019-09-03 09:30:50 +0000
commit4bafdfd240bbb39f734476d290fb2847e8010340 (patch)
treeb8e9e23b8553c20feb21a25c36c78dc78c03d218
parent6e24c8d4635efce6ce26ccdc342f8b61963b9a9e (diff)
parent97eda4fa0bdf8ae8ead6471b9efebe48edbf4a99 (diff)
Merge "Document why a separate task is needed for ansible_env.HOME"HEADmaster
-rw-r--r--xci/installer/kubespray/playbooks/configure-installer.yml4
-rw-r--r--xci/installer/osh/playbooks/configure-installer.yml4
2 files changed, 8 insertions, 0 deletions
diff --git a/xci/installer/kubespray/playbooks/configure-installer.yml b/xci/installer/kubespray/playbooks/configure-installer.yml
index 1f3b3d6f..d88ee55c 100644
--- a/xci/installer/kubespray/playbooks/configure-installer.yml
+++ b/xci/installer/kubespray/playbooks/configure-installer.yml
@@ -33,6 +33,10 @@
- { regexp: "kube_basic_auth:.*", line: "kube_basic_auth: true" }
- { regexp: "dashboard_enabled:.*", line: "dashboard_enabled: true" }
+# NOTE(fdegir): the reason for this task to be separate from the task which uses lineinfile
+# module is that escaping curly braces does not work with with_items. what happens is that
+# ansible tries to resolve {{ ansible_env.HOME }} which we don't want since it should point
+# to home folder of the user executing this task at runtime.
- name: update kubespray artifacts_dir
lineinfile:
path: "{{ xci_path }}/.cache/repos/kubespray/inventory/opnfv/group_vars/k8s-cluster/k8s-cluster.yml"
diff --git a/xci/installer/osh/playbooks/configure-installer.yml b/xci/installer/osh/playbooks/configure-installer.yml
index 905777d0..383f55fc 100644
--- a/xci/installer/osh/playbooks/configure-installer.yml
+++ b/xci/installer/osh/playbooks/configure-installer.yml
@@ -34,6 +34,10 @@
- { regexp: "kube_basic_auth:.*", line: "kube_basic_auth: true" }
- { regexp: "dashboard_enabled:.*", line: "dashboard_enabled: true" }
+# NOTE(fdegir): the reason for this task to be separate from the task which uses lineinfile
+# module is that escaping curly braces does not work with with_items. what happens is that
+# ansible tries to resolve {{ ansible_env.HOME }} which we don't want since it should point
+# to home folder of the user executing this task at runtime.
- name: update kubespray artifacts_dir
lineinfile:
path: "{{ xci_path }}/.cache/repos/kubespray/inventory/opnfv/group_vars/k8s-cluster/k8s-cluster.yml"