From e42b3b9bc690bd39a0e45bf41214aca0062bb796 Mon Sep 17 00:00:00 2001 From: Yujun Zhang Date: Wed, 23 Nov 2016 14:05:19 +0800 Subject: Update review guidelines Change-Id: Ia3e2a67762abb6369f75935c2d891f73a32e533a Signed-off-by: Yujun Zhang --- CONTRIBUTING.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 6350a862..d10f1393 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -15,9 +15,26 @@ Peer review is the most important communication channel between developers. Every subtle change to the code or document **MUST** be reviewed before submission. +Add group ``qtip-reviewers`` in `gerrit`_ when you consider a patch set is ready. + Please make sure there is at least one ``+1`` or ``+2`` from others before submitting[#f1] a patch set. +Active Reviewers +================ + +Current list of active reviewers in gerrit group ``qtip-reviewers`` + +* Serena Feng +* Taseer Ahmed +* Yujun Zhang +* Zhifeng Jiang +* Zhihui Wu + +By becoming an active reviewer, you agree to allow others to invite you as +reviewers in QTIP project freely. Any one in OPNFV community can apply to join +QTIP reviewers group or leave by submitting a patch on this document. + **************** Tasks and Issues **************** @@ -88,6 +105,7 @@ to submit. The current members are listed in `INFO`_. .. rubric:: Reference .. _Developer Getting Started: https://wiki.opnfv.org/display/DEV/Developer+Getting+Started +.. _gerrit: https://gerrit.opnfv.org/gerrit/#/q/project:+qtip .. _JIRA: https://jira.opnfv.org/browse/QTIP .. _OPNFV Releases: https://wiki.opnfv.org/display/SWREL .. _Issue Types: https://jira.opnfv.org/secure/ShowConstantsHelp.jspa?decorator=popup#IssueTypes -- cgit 1.2.3-korg