From 8a5cb9aebdb7c763fae470fa00beecf07c81fb1d Mon Sep 17 00:00:00 2001 From: Yujun Zhang Date: Wed, 22 Feb 2017 11:41:07 +0800 Subject: Refactoring qtip.runner - deprecate current PoC - cover it with test Change-Id: Ia1a43c195781fdd09e7d925ed3bf4509f226916f Signed-off-by: Yujun Zhang --- qtip/runner/__init__.py | 43 ---------------------------------------- qtip/runner/base.py | 12 +++++++++++ tests/unit/runner/runner_test.py | 16 +++++++++++++++ 3 files changed, 28 insertions(+), 43 deletions(-) create mode 100644 qtip/runner/base.py create mode 100644 tests/unit/runner/runner_test.py diff --git a/qtip/runner/__init__.py b/qtip/runner/__init__.py index 52c43a14..e69de29b 100644 --- a/qtip/runner/__init__.py +++ b/qtip/runner/__init__.py @@ -1,43 +0,0 @@ -############################################################################## -# Copyright (c) 2016 ZTE Corp and others. -# -# All rights reserved. This program and the accompanying materials -# are made available under the terms of the Apache License, Version 2.0 -# which accompanies this distribution, and is available at -# http://www.apache.org/licenses/LICENSE-2.0 -############################################################################## - -from qtip.base.constant import PkgName, BaseProp -from qtip.base.error import NotFoundError -from qtip.collector.stdout import StdoutCollector -from qtip.driver.random import RandomDriver -from qtip.reporter.console import ConsoleReporter - - -class Runner(object): - def __init__(self, spec, config=None): - if config is None: - config = spec[BaseProp.CONFIG] - - driver_name = config[BaseProp.DRIVER] - collector_name = config[BaseProp.COLLECTOR] - reporter_name = config[BaseProp.REPORTER] - - # TODO(yujunz) dynamically load modules by name - - if driver_name == 'random': - self.driver = RandomDriver() - else: - raise NotFoundError(driver_name, heystack=PkgName.DRIVER) - - if collector_name == 'stdout': - self.collector = StdoutCollector() - else: - raise NotFoundError(collector_name, - heystack=PkgName.COLLECTOR) - - if reporter_name == 'console': - self.reporter = ConsoleReporter() - else: - raise NotFoundError(reporter_name, - heystack=PkgName.REPORTER) diff --git a/qtip/runner/base.py b/qtip/runner/base.py new file mode 100644 index 00000000..a86626d9 --- /dev/null +++ b/qtip/runner/base.py @@ -0,0 +1,12 @@ +############################################################################## +# Copyright (c) 2016 ZTE Corp and others. +# +# All rights reserved. This program and the accompanying materials +# are made available under the terms of the Apache License, Version 2.0 +# which accompanies this distribution, and is available at +# http://www.apache.org/licenses/LICENSE-2.0 +############################################################################## + + +class BaseRunner(object): + """benchmark task runner""" diff --git a/tests/unit/runner/runner_test.py b/tests/unit/runner/runner_test.py new file mode 100644 index 00000000..b7da1611 --- /dev/null +++ b/tests/unit/runner/runner_test.py @@ -0,0 +1,16 @@ +############################################################################## +# Copyright (c) 2016 ZTE Corp and others. +# +# All rights reserved. This program and the accompanying materials +# are made available under the terms of the Apache License, Version 2.0 +# which accompanies this distribution, and is available at +# http://www.apache.org/licenses/LICENSE-2.0 +############################################################################## + + +from qtip.runner.base import BaseRunner + + +def test_constructor(): + runner = BaseRunner() + assert isinstance(runner, BaseRunner) -- cgit 1.2.3-korg