diff options
| author |   Yujun Zhang <zhang.yujunz@zte.com.cn> | 2017-01-11 01:56:15 +0000 |
|---|---|---|
| committer |   Gerrit Code Review <gerrit@opnfv.org> | 2017-01-11 01:56:15 +0000 |
| commit | 9fb9d1357de8c6f489b17b52c5919e978c3c930a (patch) | |
| tree | 0346690e7e9a2f9e2be98577ca2cb526fdba721c /CONTRIBUTING.md | |
| parent | 5d4afa1780f8a05e5f3e479c1eacf683a32df655 (diff) | |
| parent | 5c58e73fb903be6cf6ee17d0b572757e4be6ea2b (diff) | |
Merge "Add proposal of Fast Track review rule"
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 21 |
1 files changed, 16 insertions, 5 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a3e56317..a4929172 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,13 +13,24 @@ Peer review is the most important communication channel between developers. Every subtle change to the code or document **MUST** be reviewed before submission. -Add group `qtip-reviewers` in [gerrit][gr] when you consider a patch set is ready. +Add group `qtip-reviewers` in [gerrit][gr] when you consider a patch set is +ready. -Please make sure there is at least one `+1` or `+2` from others before -submitting a patch set. -Note: only members in `ldap/opnfv-gerrit-qtip-submitters` have permission -to submit. The current members are listed in [INFO][if]. +Rule for Submit +--------------- + +Only members in `ldap/opnfv-gerrit-qtip-submitters`, i.e. committers have +permission to submit. The current committers are listed in [INFO][if]. + +Before submitting a patch set, please make sure one of the following criteria is +met: + +* **Normal**: at least one `+2` from others +* **Fast Track**: no objection from other committers for one or more working day + +NOTE: we introduce **fast track** because currently there are not enough active +committers reviewing the patch sets. Active Reviewers ---------------- |