aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTaseer Ahmed <taseer94@gmail.com>2017-09-06 12:15:22 +0500
committerTaseer Ahmed <taseer94@gmail.com>2017-09-07 10:34:01 +0500
commit9d52bb9dd0500fa98ce3bdd8142af316adf1804e (patch)
treea68ee62e96639b891db2d349e23b0b540a2c1787
parent9ac9231cf1876719ca15f681a8fae667343a8c77 (diff)
Mitigating for missing values in storage QPI.
- Update unit tests Change-Id: I7bfe89dc6bbe1cafe13b2f3e4f9356a06a59c68b Signed-off-by: Taseer Ahmed <taseer94@gmail.com>
-rw-r--r--qtip/cli/commands/cmd_qpi.py8
-rw-r--r--tests/unit/cli/cmd_qpi_test.py7
2 files changed, 11 insertions, 4 deletions
diff --git a/qtip/cli/commands/cmd_qpi.py b/qtip/cli/commands/cmd_qpi.py
index 4865b7ae..a2802032 100644
--- a/qtip/cli/commands/cmd_qpi.py
+++ b/qtip/cli/commands/cmd_qpi.py
@@ -44,6 +44,10 @@ def show(name):
with open('{}/{}.yaml'.format(QPI_PATH, name)) as conf:
qpi = yaml.safe_load(conf)
for section in qpi['sections']:
- table.add_row([section['name'], section['description'],
- section['formula']])
+ try:
+ table.add_row([section['name'], section['description'],
+ section['formula']])
+ except Exception:
+ table.add_row([section['name'], section['description'],
+ 'Not Available'])
click.echo(table)
diff --git a/tests/unit/cli/cmd_qpi_test.py b/tests/unit/cli/cmd_qpi_test.py
index ba5f814e..fa0c859d 100644
--- a/tests/unit/cli/cmd_qpi_test.py
+++ b/tests/unit/cli/cmd_qpi_test.py
@@ -26,8 +26,11 @@ def test_list(runner):
assert 'QTIP Performance Index of compute' in result.output
-def test_show(runner):
- result = runner.invoke(cli, ['qpi', 'show', 'compute'])
+@pytest.mark.parametrize("test_input", [
+ 'storage',
+ 'compute'])
+def test_show(runner, test_input):
+ result = runner.invoke(cli, ['qpi', 'show', test_input])
assert 'QPI' in result.output
assert 'Description' in result.output
assert 'Formula' in result.output