From ff8a684abb229ce0160440291abb0e92604c809e Mon Sep 17 00:00:00 2001 From: Alexandru Avadanii Date: Fri, 12 Jan 2018 19:45:21 +0100 Subject: [PDF] Fix yamllint issues in installer adapters Although current YAML files in Pharos are all valid according to yamllint, the resulting YAMLs after PDF/IDF + IA interpolations still have a lot of violations, which need to be addressed. PDF changes: - bii/pod1: + fix typo in disks_A reference; IDF changes: - replace empty strings with `~` keyword (will be expanded to 'None'); IA (installer adapter) changes: - apex: + add missing document start; - compass4nfv: + too few spaces before comment; + missing starting space in comment; + replace '\t' with spaces; - daisy: + None; - fuel: + check conf.idf is defined first (fix parse for PODs without IDF); + move document start outside conf.idf condition - joid: + None; This is not an exhaustive change, some yamllint issues are still there but require either refactoring IAs or changing the PDF/IDF files in a way that needs the respective maintainer's input. Change-Id: I26743e265217e892b6a94de96a016c295ea24fb5 Signed-off-by: Alexandru Avadanii --- labs/lf/idf-pod2.yaml | 16 ++++++++-------- labs/lf/idf-pod5.yaml | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) (limited to 'labs/lf') diff --git a/labs/lf/idf-pod2.yaml b/labs/lf/idf-pod2.yaml index 78c916ef..c3ad1714 100644 --- a/labs/lf/idf-pod2.yaml +++ b/labs/lf/idf-pod2.yaml @@ -48,21 +48,21 @@ idf: fuel: jumphost: bridges: - admin: '' - mgmt: '' - private: '' - public: '' + admin: ~ + mgmt: ~ + private: ~ + public: ~ network: node: # Ordered-list, index should be in sync with node index in PDF - interfaces: &interfaces # Ordered-list, index should be in sync with interface index in PDF - - '' - - '' + - ~ + - ~ busaddr: &busaddr # Bus-info reported by `ethtool -i ethX` - - '' - - '' + - ~ + - ~ - interfaces: *interfaces busaddr: *busaddr - interfaces: *interfaces diff --git a/labs/lf/idf-pod5.yaml b/labs/lf/idf-pod5.yaml index e0e4af28..b7d05cfb 100644 --- a/labs/lf/idf-pod5.yaml +++ b/labs/lf/idf-pod5.yaml @@ -45,21 +45,21 @@ idf: fuel: jumphost: bridges: - admin: '' - mgmt: '' - private: '' - public: '' + admin: ~ + mgmt: ~ + private: ~ + public: ~ network: node: # Ordered-list, index should be in sync with node index in PDF - interfaces: &interfaces # Ordered-list, index should be in sync with interface index in PDF - - '' - - '' + - ~ + - ~ busaddr: &busaddr # Bus-info reported by `ethtool -i ethX` - - '' - - '' + - ~ + - ~ - interfaces: *interfaces busaddr: *busaddr - interfaces: *interfaces -- cgit 1.2.3-korg