From 487b624904a58b11e3ab236bf6e663da37d2afcd Mon Sep 17 00:00:00 2001 From: Alexandru Avadanii Date: Sat, 13 Jan 2018 18:35:04 +0100 Subject: [PDF] Add schema validation - create new YAML schema for PDF validation; - add basic python script for checking a PDF against the schema; - add bash wrapper for checking all PDFs in Pharos, to be leveraged later via a new verify CI job; Change-Id: I47e02642756b7a231138dec3d5258b100b4db72b Signed-off-by: Alexandru Avadanii --- config/pdf/pod1.schema.yaml | 182 ++++++++++++++++++++++++++++++++++++++++ config/utils/check-schema.sh | 37 ++++++++ config/utils/validate_schema.py | 27 ++++++ 3 files changed, 246 insertions(+) create mode 100644 config/pdf/pod1.schema.yaml create mode 100755 config/utils/check-schema.sh create mode 100755 config/utils/validate_schema.py diff --git a/config/pdf/pod1.schema.yaml b/config/pdf/pod1.schema.yaml new file mode 100644 index 00000000..12ce38d5 --- /dev/null +++ b/config/pdf/pod1.schema.yaml @@ -0,0 +1,182 @@ +############################################################################## +# Copyright (c) 2018 Enea AB and others. +# All rights reserved. This program and the accompanying materials +# are made available under the terms of the Apache License, Version 2.0 +# which accompanies this distribution, and is available at +# http://www.apache.org/licenses/LICENSE-2.0 +############################################################################## +--- +$schema: 'http://json-schema.org/schema#' +$id: 'https://github.com/opnfv/pharos/blob/master/config/pdf/pod1.yaml' + +definitions: + ip_address: + type: 'string' # NOTE: we don't validate this is a valid addr (yet) + mac_address: + type: 'string' + pattern: '^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$' + # Common node schema for jumpserver, cluster nodes + node: + type: 'object' + properties: + type: + type: 'string' + enum: ['baremetal', 'virtual'] + vendor: + type: 'string' + model: + type: 'string' + arch: + type: 'string' + enum: ['aarch64', 'x86_64'] + cpus: + type: 'number' + cpu_cflags: + type: 'string' + cores: + type: 'number' + memory: + type: 'string' + pattern: '^[0-9]+[GT]B?$' + required: ['type', 'vendor', 'model', 'arch', 'cpus', 'cpu_cflags', 'cores', 'memory'] + additionalProperties: false + disks: + type: 'array' + items: + type: 'object' + properties: + name: + type: 'string' + pattern: '^disk[0-9]+$' + disk_capacity: + type: 'string' + pattern: '^[0-9]+[MGT]B?$' + disk_type: + type: 'string' + enum: ['hdd', 'ssd', 'cdrom', 'tape'] + disk_interface: + type: 'string' + enum: ['sata', 'sas', 'ssd', 'nvme'] + disk_rotation: + type: 'number' + enum: [5400, 7200, 10000, 15000] + required: ['name', 'disk_capacity', 'disk_type', 'disk_interface', 'disk_rotation'] + additionalProperties: false + remote_management: + type: 'object' + properties: + type: + type: 'string' + enum: ['ipmi', 'amt'] + versions: + type: 'array' + items: + type: 'number' + enum: [1.0, 2.0] + user: + type: 'string' + pass: + type: 'string' + address: + $ref: '#/definitions/ip_address' + mac_address: + $ref: '#/definitions/mac_address' + required: ['type', 'versions', 'user', 'pass', 'address', 'mac_address'] + additionalProperties: false + interfaces: + type: 'array' + items: + type: 'object' + properties: + name: + type: 'string' + pattern: '^nic[0-9]+$' + mac_address: + $ref: '#/definitions/mac_address' + # Optional + address: + $ref: '#/definitions/ip_address' + # Optional + vlan: + oneOf: + - type: 'string' + pattern: '^(native|[1-9][0-9]{0,3})(\|(native|[1-9][0-9]{0,3}))*$' + - type: 'integer' + mininum: 1 + maximum: 4095 + # Optional + speed: + type: 'string' + enum: ['1gb', '10gb', '25gb', '40gb'] + # FIXME: mandatory for nodes? + # Optional + features: + type: ['string', 'null'] + pattern: '^((dpdk|sriov)\|?)*$' + # FIXME: mandatory for nodes? + required: ['name', 'mac_address'] + additionalProperties: false + +# Do not allow any properties not defined here. This lets us catch typos. +additionalProperties: false + +properties: + details: + type: 'object' + properties: + type: + type: 'string' + enum: ['production', 'development'] + pod_owner: + type: 'string' + contact: + type: 'string' + pattern: '^([a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+[,; ]*)+$' + lab: + type: 'string' + location: + type: 'string' + link: + type: 'string' + required: ['type', 'pod_owner', 'contact', 'lab', 'location', 'link'] + additionalProperties: false + jumphost: + type: 'object' + properties: + name: + type: 'string' + node: + $ref: '#/definitions/node' + disks: + $ref: '#/definitions/disks' + os: + type: 'string' + remote_params: # Optional YAML anchor, contents will be validated below + type: 'object' + remote_management: + $ref: '#/definitions/remote_management' + interfaces: + $ref: '#/definitions/interfaces' + required: ['name', 'node', 'disks', 'os', 'remote_management', 'interfaces'] + additionalProperties: false + nodes: + type: 'array' + items: + type: 'object' + properties: + name: + type: 'string' + node: + $ref: '#/definitions/node' + disks: + $ref: '#/definitions/disks' + os: + type: 'string' + remote_params: # Optional YAML anchor, contents will be validated after inject + type: 'object' + remote_management: + $ref: '#/definitions/remote_management' + interfaces: + $ref: '#/definitions/interfaces' + required: ['name', 'node', 'disks', 'remote_management', 'interfaces'] + additionalProperties: false diff --git a/config/utils/check-schema.sh b/config/utils/check-schema.sh new file mode 100755 index 00000000..321c5ced --- /dev/null +++ b/config/utils/check-schema.sh @@ -0,0 +1,37 @@ +#!/bin/bash -e +############################################################################## +# Copyright (c) 2018 Enea AB and others. +# All rights reserved. This program and the accompanying materials +# are made available under the terms of the Apache License, Version 2.0 +# which accompanies this distribution, and is available at +# http://www.apache.org/licenses/LICENSE-2.0 +############################################################################## + +export PATH=$PATH:/usr/local/bin/ + +VALIDATE_SCHEMA='./config/utils/validate_schema.py' +PDF_SCHEMA='./config/pdf/pod1.schema.yaml' +RC=0 + +while IFS= read -r lab_config; do + pdf_cmd="${VALIDATE_SCHEMA} -s ${PDF_SCHEMA} -y ${lab_config}" + echo "###################### ${lab_config} ######################" + pdf_out=$(${pdf_cmd} |& sed 's|ENC\[PKCS.*\]|opnfv|g') + if [ -z "${pdf_out}" ]; then + SUMMARY+=";${lab_config#labs/};OK;\n" + echo "[PDF] [OK] ${pdf_cmd}" + else + SUMMARY+=";${lab_config#labs/};ERROR;\n" + RC=1 + echo "${pdf_out}" + echo "[PDF] [ERROR] ${pdf_cmd}" + fi + echo '' +done < <(find 'labs' -name 'pod*.yaml') + +cat < Date: Sat, 13 Jan 2018 19:43:48 +0100 Subject: [PDF] [SPEC] Extend disk_rotation enum with '0' ssd and nvme drives are static, so extend the list of accepted disk_rotation values to accomodate this. Use '0' so the enum can still be parsed as a numeric value. Change-Id: Ib8ef8cceb495c7eb588c68d151690747463167f5 Signed-off-by: Alexandru Avadanii --- config/pdf/pod1.schema.yaml | 2 +- config/pdf/pod1.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/pdf/pod1.schema.yaml b/config/pdf/pod1.schema.yaml index 12ce38d5..ad7466e0 100644 --- a/config/pdf/pod1.schema.yaml +++ b/config/pdf/pod1.schema.yaml @@ -59,7 +59,7 @@ definitions: enum: ['sata', 'sas', 'ssd', 'nvme'] disk_rotation: type: 'number' - enum: [5400, 7200, 10000, 15000] + enum: [0, 5400, 7200, 10000, 15000] required: ['name', 'disk_capacity', 'disk_type', 'disk_interface', 'disk_rotation'] additionalProperties: false remote_management: diff --git a/config/pdf/pod1.yaml b/config/pdf/pod1.yaml index d9028c23..03ec9d12 100644 --- a/config/pdf/pod1.yaml +++ b/config/pdf/pod1.yaml @@ -34,7 +34,7 @@ jumphost: # several interface types possible disk_interface: {sata|sas|ssd|nvme} # define rotation speed of disk - disk_rotation: {5400|7200|10000|15000} + disk_rotation: {0|5400|7200|10000|15000} # second disk - name: 'disk2' disk_capacity: 2048G -- cgit 1.2.3-korg From 351fc8c910b9830c2ecdd86a265e1e2a3c36f70d Mon Sep 17 00:00:00 2001 From: Alexandru Avadanii Date: Sat, 13 Jan 2018 20:29:16 +0100 Subject: [PDF] [SPEC] Align interface keys for NIC names Jumpserver and cluster nodes use different keys for defining the NIC name ('nic' vs 'name'), switch all of them to 'name' for uniformity. Change-Id: I2d7720f5e5349ef59cf76a0e07749cfbd0d34d0b Signed-off-by: Alexandru Avadanii --- config/pdf/pod1.encrypted.yaml | 4 ++-- config/pdf/pod1.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/pdf/pod1.encrypted.yaml b/config/pdf/pod1.encrypted.yaml index 8693647d..2390ee03 100644 --- a/config/pdf/pod1.encrypted.yaml +++ b/config/pdf/pod1.encrypted.yaml @@ -77,14 +77,14 @@ jumphost: # physical interface list interfaces: # first interface - - nic: {nic#number} + - name: {nic#number} # ip address of nic address: 192.168.100.1 mac_address: "10:23:45:67:89:AC" # vlan tag, may have multiple tags vlan: {native|1-4095} # second interface - - nic: 'nic2' + - name: 'nic2' address: 10.20.0.1/24 mac_address: "10:23:45:67:89:5B" nodes: diff --git a/config/pdf/pod1.yaml b/config/pdf/pod1.yaml index 03ec9d12..2385d8af 100644 --- a/config/pdf/pod1.yaml +++ b/config/pdf/pod1.yaml @@ -58,14 +58,14 @@ jumphost: # physical interface list interfaces: # first interface - - nic: {nic#number} + - name: {nic#number} # ip address of nic address: 192.168.100.1 mac_address: "10:23:45:67:89:AC" # vlan tag, may have multiple tags vlan: {native|1-4095} # second interface - - nic: 'nic2' + - name: 'nic2' address: 10.20.0.1/24 mac_address: "10:23:45:67:89:5B" nodes: -- cgit 1.2.3-korg From 0a2ae9f913482b0439a00ca9784d74065a3a0c7d Mon Sep 17 00:00:00 2001 From: Alexandru Avadanii Date: Sat, 13 Jan 2018 22:47:56 +0100 Subject: [PDF] [SPEC] disk_interface: Add 'scsi', 'iscsi' zte-pod3 and ericsson-pod1 define their disk interfaces as (i)SCSI. Change-Id: I97945f7a41eec4e8a38de544af95ce4af82df200 Signed-off-by: Alexandru Avadanii --- config/pdf/pod1.encrypted.yaml | 2 +- config/pdf/pod1.schema.yaml | 2 +- config/pdf/pod1.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/pdf/pod1.encrypted.yaml b/config/pdf/pod1.encrypted.yaml index 2390ee03..5679de66 100644 --- a/config/pdf/pod1.encrypted.yaml +++ b/config/pdf/pod1.encrypted.yaml @@ -32,7 +32,7 @@ jumphost: # several disk types possible disk_type: {hdd|ssd|cdrom|tape} # several interface types possible - disk_interface: {sata|sas|ssd|nvme} + disk_interface: {sata|sas|ssd|nvme|scsi|iscsi} # define rotation speed of disk disk_rotation: {5400|7200|10000|15000} # second disk diff --git a/config/pdf/pod1.schema.yaml b/config/pdf/pod1.schema.yaml index ad7466e0..a602b562 100644 --- a/config/pdf/pod1.schema.yaml +++ b/config/pdf/pod1.schema.yaml @@ -56,7 +56,7 @@ definitions: enum: ['hdd', 'ssd', 'cdrom', 'tape'] disk_interface: type: 'string' - enum: ['sata', 'sas', 'ssd', 'nvme'] + enum: ['sata', 'sas', 'ssd', 'nvme', 'scsi', 'iscsi'] disk_rotation: type: 'number' enum: [0, 5400, 7200, 10000, 15000] diff --git a/config/pdf/pod1.yaml b/config/pdf/pod1.yaml index 2385d8af..a2a1e555 100644 --- a/config/pdf/pod1.yaml +++ b/config/pdf/pod1.yaml @@ -32,7 +32,7 @@ jumphost: # several disk types possible disk_type: {hdd|ssd|cdrom|tape} # several interface types possible - disk_interface: {sata|sas|ssd|nvme} + disk_interface: {sata|sas|ssd|nvme|scsi|iscsi} # define rotation speed of disk disk_rotation: {0|5400|7200|10000|15000} # second disk -- cgit 1.2.3-korg