From 58a44a8ea1e48ba8936485086794cb59795a2d03 Mon Sep 17 00:00:00 2001 From: Gwenael Lambrouin Date: Tue, 24 Aug 2021 11:42:26 +0200 Subject: Be explicit about text file encoding Python PEP 597 (https://www.python.org/dev/peps/pep-0597) recommends to use an explicit encoding for text files instead of the default locale encoding. Pylint 2.10 adds a new checker named unspecified-encoding for that. The present patch adds explicit utf-8 encoding to open() calls in nfvbench and fixes pylint unspecified-encoding warnings. Remark: this patch does not change nfvbench behaviour on systems where utf-8 is the locale encoding, which is generally the case on Linux systems. Change-Id: Ic4dfb37e1ea958452a0173f7630a68f0d95071ae Signed-off-by: Gwenael Lambrouin --- nfvbench/traffic_gen/trex_gen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'nfvbench/traffic_gen/trex_gen.py') diff --git a/nfvbench/traffic_gen/trex_gen.py b/nfvbench/traffic_gen/trex_gen.py index 41768b1..dff72ac 100644 --- a/nfvbench/traffic_gen/trex_gen.py +++ b/nfvbench/traffic_gen/trex_gen.py @@ -761,7 +761,7 @@ class TRex(AbstractTrafficGenerator): after = None last = None try: - with open('/tmp/trex.log', 'r') as trex_log: + with open('/tmp/trex.log', 'r', encoding="utf-8") as trex_log: for _line in trex_log: line = _line.strip() if line.startswith('Usage:'): @@ -912,7 +912,7 @@ class TRex(AbstractTrafficGenerator): break last_size = size time.sleep(1) - with open(logpath, 'r') as f: + with open(logpath, 'r', encoding="utf-8") as f: message = f.read() else: message = e.message -- cgit 1.2.3-korg