From 480d0fb4390de27b225722e72cb95686f5c42ff8 Mon Sep 17 00:00:00 2001
From: WuKong <rebirthmonkey@gmail.com>
Date: Wed, 23 Sep 2015 11:58:00 +0200
Subject: review moonclient

Change-Id: I0969fe42fd756c025d549d0cffe07943cddd2d15
Signed-off-by: WuKong <rebirthmonkey@gmail.com>
---
 moonclient/moonclient/actions.py | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

(limited to 'moonclient/moonclient/actions.py')

diff --git a/moonclient/moonclient/actions.py b/moonclient/moonclient/actions.py
index f5947b32..f2550579 100644
--- a/moonclient/moonclient/actions.py
+++ b/moonclient/moonclient/actions.py
@@ -10,7 +10,7 @@ from cliff.command import Command
 
 
 class ActionsList(Lister):
-    """List all Intra_Extensions."""
+    """List all actions."""
 
     log = logging.getLogger(__name__)
 
@@ -35,7 +35,7 @@ class ActionsList(Lister):
 
 
 class ActionsAdd(Command):
-    """List all Intra_Extensions."""
+    """Add a new action."""
 
     log = logging.getLogger(__name__)
 
@@ -61,11 +61,10 @@ class ActionsAdd(Command):
     def take_action(self, parsed_args):
         if not parsed_args.intraextension:
             parsed_args.intraextension = self.app.intraextension
-        data = self.app.get_url("/v3/OS-MOON/intra_extensions/{}/actions".format(parsed_args.intraextension),
+        data = self.app.get_url("/v3/OS-MOON/intra_extensions/{}/actions".format(parsed_args.intraextension),  # TODO: check method POST?
                                 post_data={
                                     "action_name": parsed_args.action_name,
-                                    "action_description": parsed_args.description,
-                                },
+                                    "action_description": parsed_args.description},
                                 authtoken=True)
         return (
             ("id", "name", "description"),
@@ -74,14 +73,14 @@ class ActionsAdd(Command):
 
 
 class ActionsDelete(Command):
-    """List all Intra_Extensions."""
+    """Delete an action."""
 
     log = logging.getLogger(__name__)
 
     def get_parser(self, prog_name):
         parser = super(ActionsDelete, self).get_parser(prog_name)
         parser.add_argument(
-            'action',
+            'action_id',
             metavar='<action-uuid>',
             help='Action UUID',
         )
@@ -97,7 +96,7 @@ class ActionsDelete(Command):
             parsed_args.intraextension = self.app.intraextension
         self.app.get_url("/v3/OS-MOON/intra_extensions/{}/actions/{}".format(
             parsed_args.intraextension,
-            parsed_args.action
-        ),
+            parsed_args.action_id),
             method="DELETE",
-            authtoken=True)
\ No newline at end of file
+            authtoken=True
+        )
\ No newline at end of file
-- 
cgit 1.2.3-korg