From 5dffe7e0889dd76885d313c1d44a4b389f4b8667 Mon Sep 17 00:00:00 2001
From: "ahmed.helmy" <ahmad.helmy@orange.com>
Date: Thu, 5 Apr 2018 15:41:37 +0200
Subject: continue integrating validation

Change-Id: Ifbda169affd649f9125581ac5b688b509d1f0d82
Signed-off-by: ahmed.helmy <ahmad.helmy@orange.com>
---
 moon_manager/tests/unit_python/api/test_rules.py | 58 +++++++++++++++++++++++-
 1 file changed, 57 insertions(+), 1 deletion(-)

(limited to 'moon_manager/tests/unit_python/api/test_rules.py')

diff --git a/moon_manager/tests/unit_python/api/test_rules.py b/moon_manager/tests/unit_python/api/test_rules.py
index 0b302494..d12b7186 100644
--- a/moon_manager/tests/unit_python/api/test_rules.py
+++ b/moon_manager/tests/unit_python/api/test_rules.py
@@ -23,6 +23,35 @@ def add_rules(client, policy_id):
     return req, rules
 
 
+def add_rules_without_meta_rule_id(client, policy_id):
+    data = {
+        "meta_rule_id": "",
+        "rule": ["subject_data_id2", "object_data_id2", "action_data_id2"],
+        "instructions": (
+            {"decision": "grant"},
+        ),
+        "enabled": True
+    }
+    req = client.post("/policies/{}/rules".format(policy_id), data=json.dumps(data),
+                      headers={'Content-Type': 'application/json'})
+    rules = utilities.get_json(req.data)
+    return req, rules
+
+
+def add_rules_without_rule(client, policy_id):
+    data = {
+        "meta_rule_id": "meta_rule_id1",
+        "instructions": (
+            {"decision": "grant"},
+        ),
+        "enabled": True
+    }
+    req = client.post("/policies/{}/rules".format(policy_id), data=json.dumps(data),
+                      headers={'Content-Type': 'application/json'})
+    rules = utilities.get_json(req.data)
+    return req, rules
+
+
 def delete_rules(client, policy_id, meta_rule_id):
     req = client.delete("/policies/{}/rules/{}".format(policy_id, meta_rule_id))
     return req
@@ -50,10 +79,37 @@ def test_add_rules():
     assert value[id]["meta_rule_id"] == "meta_rule_id1"
 
 
+def test_add_rules_without_policy_id():
+    client = utilities.register_client()
+    req, rules = add_rules(client, None)
+    assert req.status_code == 500
+
+
+def test_add_rules_without_meta_rule_id():
+    policy_id = utilities.get_policy_id()
+    client = utilities.register_client()
+    req, rules = add_rules_without_meta_rule_id(client, policy_id)
+    assert req.status_code == 500
+    assert json.loads(req.data)["message"] == 'Empty String'
+
+
+def test_add_rules_without_rule():
+    policy_id = utilities.get_policy_id()
+    client = utilities.register_client()
+    req, rules = add_rules_without_rule(client, policy_id)
+    assert req.status_code == 500
+
+
 def test_delete_rules():
+    client = utilities.register_client()
+    rules = delete_rules(client, "", "")
+    assert rules.status_code == 500
+
+
+def test_delete_rules_without_policy_id():
     client = utilities.register_client()
     policy_id = utilities.get_policy_id()
     req, added_rules = get_rules(client, policy_id)
     id = added_rules["rules"]['rules'][0]['id']
-    rules = delete_rules(client, policy_id, id)
+    rules = delete_rules(client, None, id)
     assert rules.status_code == 200
-- 
cgit 1.2.3-korg