From 8b21d5190469230644506ec561762d452a46b933 Mon Sep 17 00:00:00 2001 From: Linda Wang Date: Thu, 30 Nov 2017 02:31:17 +0000 Subject: Stop updating test_db_url in config file by env var If TEST_DB_URL is declared in env variable, use it before considering the var in config file. Change-Id: I656ad8765287c48d60af7ab88b421805d76fb231 Signed-off-by: Linda Wang --- functest/tests/unit/ci/test_run_tests.py | 34 ++------------------------------ 1 file changed, 2 insertions(+), 32 deletions(-) (limited to 'functest/tests/unit/ci/test_run_tests.py') diff --git a/functest/tests/unit/ci/test_run_tests.py b/functest/tests/unit/ci/test_run_tests.py index fc689452d..b5af18c97 100644 --- a/functest/tests/unit/ci/test_run_tests.py +++ b/functest/tests/unit/ci/test_run_tests.py @@ -7,7 +7,6 @@ import logging import unittest -import os import mock @@ -72,19 +71,9 @@ class RunTestsTesting(unittest.TestCase): 'openstack': {'image_name': 'test_image_name_3'}}}} @mock.patch('functest.ci.run_tests.Runner.patch_file') - @mock.patch('functest.ci.run_tests.Runner.update_db_url') - def test_update_config_file_default(self, *mock_methods): + def test_update_config_file_default(self, mock_patch): self.runner.update_config_file() - mock_methods[1].assert_called() - mock_methods[0].assert_not_called() - - @mock.patch('functest.ci.run_tests.Runner.patch_file') - @mock.patch('functest.ci.run_tests.Runner.update_db_url') - @mock.patch.dict(os.environ, {'TEST_DB_URL': 'somevalue'}) - def test_update_config_file_update_db(self, *mock_methods): - self.runner.update_config_file() - mock_methods[1].assert_called() - mock_methods[0].assert_called() + mock_patch.assert_called() def test_patch_file_missing_file(self): patch_file_path = "unexisting_file" @@ -119,25 +108,6 @@ class RunTestsTesting(unittest.TestCase): mock_methods[1].assert_called() mock_methods[0].assert_called() - def test_update_db_url_missing_file(self): - run_tests.CONFIG_FUNCTEST_PATH = "unexisting_file" - with self.assertRaises(IOError): - self.runner.update_db_url() - - @mock.patch('functest.ci.run_tests.yaml.safe_load') - @mock.patch('functest.ci.run_tests.ft_utils.get_functest_yaml') - @mock.patch.dict(os.environ, {'TEST_DB_URL': 'url2'}) - def test_update_db_url_default(self, *mock_methods): - with mock.patch( - 'six.moves.builtins.open', mock.mock_open()), mock.patch( - 'functest.ci.run_tests.yaml.safe_load') as yaml1: - yaml1.return_value = self.config_file_yaml - self.runner.update_db_url() - self.assertEqual( - yaml1.return_value['results']['test_db_url'], 'url2') - mock_methods[0].assert_not_called() - mock_methods[1].assert_not_called() - @mock.patch('functest.ci.run_tests.logger.error') def test_source_rc_file_missing_file(self, mock_logger_error): with mock.patch('functest.ci.run_tests.os.path.isfile', -- cgit 1.2.3-korg