From de85f0b134d3e6aaeb3f81c93fd70dc72d92d785 Mon Sep 17 00:00:00 2001 From: "guillaume.lambert" Date: Tue, 10 May 2022 22:04:23 +0200 Subject: Stop bashing functest scripts Though bash is a good interactive user shell and apart portability concerns, many UN*X systems and GNU+Linux distributions now prefers Almquist or Kornshell variants for scripting in order to improve the system performance and maintenability. https://wiki.ubuntu.com/DashAsBinSh https://mywiki.wooledge.org/Bashism https://en.wikipedia.org/wiki/Almquist_shell Signed-off-by: guillaume.lambert Change-Id: I32c5490f9eab54e6cac594f3eac1e392edf8b272 (cherry picked from commit b9fedb6868306a6e3145b7ee851ea3a84353df9c) --- README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'README.md') diff --git a/README.md b/README.md index a8fb4c5e5..a1d201e1b 100644 --- a/README.md +++ b/README.md @@ -49,7 +49,7 @@ export OS_IDENTITY_API_VERSION=3 export OS_REGION_NAME=XXX ``` -mkdir -p images && wget -q -O- https://git.opnfv.org/functest/plain/functest/ci/download_images.sh | bash -s -- images && ls -1 images/* +mkdir -p images && wget -q -O- https://git.opnfv.org/functest/plain/functest/ci/download_images.sh | sh -s -- images && ls -1 images/* ``` images/cirros-0.5.1-aarch64-disk.img images/cirros-0.5.1-x86_64-disk.img @@ -64,7 +64,7 @@ images/vyos-1.1.8-amd64.qcow2 ## Run healthcheck suite -```bash +```shell sudo docker run --env-file env \ -v $(pwd)/openstack.creds:/home/opnfv/functest/conf/env_file \ -v $(pwd)/images:/home/opnfv/functest/images \ @@ -93,7 +93,7 @@ sudo docker run --env-file env \ ## Run smoke suite -```bash +```shell sudo docker run --env-file env \ -v $(pwd)/openstack.creds:/home/opnfv/functest/conf/env_file \ -v $(pwd)/images:/home/opnfv/functest/images \ @@ -127,7 +127,7 @@ sudo docker run --env-file env \ ## Run smoke CNTT suite -```bash +```shell sudo docker run --env-file env \ -v $(pwd)/openstack.creds:/home/opnfv/functest/conf/env_file \ -v $(pwd)/images:/home/opnfv/functest/images \ @@ -151,7 +151,7 @@ sudo docker run --env-file env \ ## Run benchmarking suite -```bash +```shell sudo docker run --env-file env \ -v $(pwd)/openstack.creds:/home/opnfv/functest/conf/env_file \ -v $(pwd)/images:/home/opnfv/functest/images \ @@ -171,7 +171,7 @@ sudo docker run --env-file env \ ## Run benchmarking CNTT suite -```bash +```shell sudo docker run --env-file env \ -v $(pwd)/openstack.creds:/home/opnfv/functest/conf/env_file \ -v $(pwd)/images:/home/opnfv/functest/images \ @@ -191,7 +191,7 @@ sudo docker run --env-file env \ ## Run vnf suite -```bash +```shell sudo docker run --env-file env \ -v $(pwd)/openstack.creds:/home/opnfv/functest/conf/env_file \ -v $(pwd)/images:/home/opnfv/functest/images \ -- cgit