From a4bbcd895a0fbf29cb7c2dc396fefb4229573225 Mon Sep 17 00:00:00 2001 From: Cédric Ollivier Date: Tue, 31 Jul 2018 12:25:40 +0200 Subject: Print stderr in logs when calling cmd over ssh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I152ac898661a0e99a6232df86689c70c468ceaa5 Signed-off-by: Cédric Ollivier (cherry picked from commit b66827d753e09c29cd6f541119dc0ec4c6344511) --- functest/core/singlevm.py | 3 ++- functest/opnfv_tests/openstack/vping/vping_ssh.py | 5 +++-- functest/tests/unit/openstack/vping/test_vping_ssh.py | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/functest/core/singlevm.py b/functest/core/singlevm.py index 2a8ae879a..46aa41902 100644 --- a/functest/core/singlevm.py +++ b/functest/core/singlevm.py @@ -381,8 +381,9 @@ class SingleVm1(VmReady1): Returns: echo exit codes """ - (_, stdout, _) = self.ssh.exec_command('echo Hello World') + (_, stdout, stderr) = self.ssh.exec_command('echo Hello World') self.__logger.debug("output:\n%s", stdout.read()) + self.__logger.debug("error:\n%s", stderr.read()) return stdout.channel.recv_exit_status() def run(self, **kwargs): diff --git a/functest/opnfv_tests/openstack/vping/vping_ssh.py b/functest/opnfv_tests/openstack/vping/vping_ssh.py index 643f4f6de..a8a6fd9a6 100644 --- a/functest/opnfv_tests/openstack/vping/vping_ssh.py +++ b/functest/opnfv_tests/openstack/vping/vping_ssh.py @@ -44,9 +44,10 @@ class VPingSSH(singlevm.SingleVm2): Returns: ping exit codes """ assert self.ssh - (_, stdout, _) = self.ssh.exec_command( + (_, stdout, stderr) = self.ssh.exec_command( 'ping -c 1 ' + self.vm2.private_v4) - self.__logger.debug("output:\n%s", stdout.read()) + self.__logger.info("output:\n%s", stdout.read()) + self.__logger.info("error:\n%s", stderr.read()) return stdout.channel.recv_exit_status() def clean(self): diff --git a/functest/tests/unit/openstack/vping/test_vping_ssh.py b/functest/tests/unit/openstack/vping/test_vping_ssh.py index 3595638ec..05482ed6b 100644 --- a/functest/tests/unit/openstack/vping/test_vping_ssh.py +++ b/functest/tests/unit/openstack/vping/test_vping_ssh.py @@ -75,7 +75,7 @@ class VpingSSHTesting(unittest.TestCase): self.vping.ssh = mock.Mock() stdout = mock.Mock() stdout.channel.recv_exit_status.return_value = ret - self.vping.ssh.exec_command.return_value = (None, stdout, None) + self.vping.ssh.exec_command.return_value = (None, stdout, mock.Mock()) self.assertEqual(self.vping.execute(), ret) self.vping.ssh.exec_command.assert_called_once_with( 'ping -c 1 {}'.format(self.vping.vm2.private_v4)) -- cgit 1.2.3-korg