From 87087a17296a1297dfb20e2f092d79c166855439 Mon Sep 17 00:00:00 2001
From: Juha Kosonen <juha.kosonen@nokia.com>
Date: Thu, 15 Aug 2019 16:15:21 +0300
Subject: Fix rally task file manipulation

Remove empty workload entries when applying blacklist in RallyJobs.
Rally considers task file as invalid if it contains entries whose
workload list empty.

Change-Id: I34867c0aeea9c5ecf1294959d680e6de535be9cd
Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
---
 functest/opnfv_tests/openstack/rally/rally.py | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/functest/opnfv_tests/openstack/rally/rally.py b/functest/opnfv_tests/openstack/rally/rally.py
index 7438d7155..22b508afa 100644
--- a/functest/opnfv_tests/openstack/rally/rally.py
+++ b/functest/opnfv_tests/openstack/rally/rally.py
@@ -769,26 +769,26 @@ class RallyJobs(RallyBase):
                     cases.pop(name)
         else:
             # workloads in subtasks
-            for sind, subtask in enumerate(cases.get('subtasks', [])):
-                idx = []
-                for wind, workload in enumerate(subtask.get('workloads', [])):
+            for sind, subtask in reversed(list(
+                    enumerate(cases.get('subtasks', [])))):
+                for wind, workload in reversed(list(
+                        enumerate(subtask.get('workloads', [])))):
                     scenario = workload.get('scenario', {})
                     for name in scenario.keys():
                         if self.in_iterable_re(name, black_tests):
-                            idx.append(wind)
+                            cases['subtasks'][sind]['workloads'].pop(wind)
                             break
-                for wind in reversed(idx):
-                    cases['subtasks'][sind]['workloads'].pop(wind)
+                if 'workloads' in cases['subtasks'][sind]:
+                    if not cases['subtasks'][sind]['workloads']:
+                        cases['subtasks'].pop(sind)
             # scenarios in subtasks
-            idx = []
-            for sind, subtask in enumerate(cases.get('subtasks', [])):
+            for sind, subtask in reversed(list(
+                    enumerate(cases.get('subtasks', [])))):
                 scenario = subtask.get('scenario', {})
                 for name in scenario.keys():
                     if self.in_iterable_re(name, black_tests):
-                        idx.append(sind)
+                        cases['subtasks'].pop(sind)
                         break
-            for sind in reversed(idx):
-                cases['subtasks'].pop(sind)
 
         with open(result_file_name, 'w') as fname:
             template.dump(cases, fname)
-- 
cgit 

es/nsut/router/tc_heat_external_rfc2544_ipv4_128Kflows_5cores_2ports_1518B.yaml?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>diff</a><a href='/yardstick/stats/samples/vnf_samples/nsut/router/tc_heat_external_rfc2544_ipv4_128Kflows_5cores_2ports_1518B.yaml'>stats</a></td><td class='form'><form class='right' method='get' action='/yardstick/log/samples/vnf_samples/nsut/router/tc_heat_external_rfc2544_ipv4_128Kflows_5cores_2ports_1518B.yaml'>
<input type='hidden' name='id' value='39f80e9b06395ae1515cfcf08508504ad4dd978a'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/yardstick/tree/?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>root</a>/<a href='/yardstick/tree/samples?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>samples</a>/<a href='/yardstick/tree/samples/vnf_samples?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>vnf_samples</a>/<a href='/yardstick/tree/samples/vnf_samples/nsut?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>nsut</a>/<a href='/yardstick/tree/samples/vnf_samples/nsut/router?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>router</a>/<a href='/yardstick/tree/samples/vnf_samples/nsut/router/tc_heat_external_rfc2544_ipv4_128Kflows_5cores_2ports_1518B.yaml?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>tc_heat_external_rfc2544_ipv4_128Kflows_5cores_2ports_1518B.yaml</a></div><div class='content'>blob: fb7f48a2f9785085d4ca2ed0e31fc14b2d9dbda7 (<a href='/yardstick/plain/samples/vnf_samples/nsut/router/tc_heat_external_rfc2544_ipv4_128Kflows_5cores_2ports_1518B.yaml?id=39f80e9b06395ae1515cfcf08508504ad4dd978a'>plain</a>)
<table summary='blob content' class='blob'>
<tr><td class='linenumbers'><pre><a id='n1' href='#n1'>1</a>
<a id='n2' href='#n2'>2</a>
<a id='n3' href='#n3'>3</a>
<a id='n4' href='#n4'>4</a>
<a id='n5' href='#n5'>5</a>
<a id='n6' href='#n6'>6</a>
<a id='n7' href='#n7'>7</a>
<a id='n8' href='#n8'>8</a>
<a id='n9' href='#n9'>9</a>
<a id='n10' href='#n10'>10</a>
<a id='n11' href='#n11'>11</a>
<a id='n12' href='#n12'>12</a>
<a id='n13' href='#n13'>13</a>
<a id='n14' href='#n14'>14</a>
<a id='n15' href='#n15'>15</a>
<a id='n16' href='#n16'>16</a>
<a id='n17' href='#n17'>17</a>
<a id='n18' href='#n18'>18</a>
<a id='n19' href='#n19'>19</a>
<a id='n20' href='#n20'>20</a>
<a id='n21' href='#n21'>21</a>
<a id='n22' href='#n22'>22</a>
<a id='n23' href='#n23'>23</a>
<a id='n24' href='#n24'>24</a>
<a id='n25' href='#n25'>25</a>
<a id='n26' href='#n26'>26</a>
<a id='n27' href='#n27'>27</a>
<a id='n28' href='#n28'>28</a>
<a id='n29' href='#n29'>29</a>
<a id='n30' href='#n30'>30</a>
<a id='n31' href='#n31'>31</a>
<a id='n32' href='#n32'>32</a>
<a id='n33' href='#n33'>33</a>
<a id='n34' href='#n34'>34</a>
<a id='n35' href='#n35'>35</a>
<a id='n36' href='#n36'>36</a>
<a id='n37' href='#n37'>37</a>
<a id='n38' href='#n38'>38</a>
<a id='n39' href='#n39'>39</a>
<a id='n40' href='#n40'>40</a>
<a id='n41' href='#n41'>41</a>
<a id='n42' href='#n42'>42</a>
<a id='n43' href='#n43'>43</a>
<a id='n44' href='#n44'>44</a>
<a id='n45' href='#n45'>45</a>
<a id='n46' href='#n46'>46</a>
<a id='n47' href='#n47'>47</a>
<a id='n48' href='#n48'>48</a>
<a id='n49' href='#n49'>49</a>
<a id='n50' href='#n50'>50</a>
<a id='n51' href='#n51'>51</a>
<a id='n52' href='#n52'>52</a>
<a id='n53' href='#n53'>53</a>
<a id='n54' href='#n54'>54</a>
<a id='n55' href='#n55'>55</a>
<a id='n56' href='#n56'>56</a>
<a id='n57' href='#n57'>57</a>
<a id='n58' href='#n58'>58</a>
<a id='n59' href='#n59'>59</a>
<a id='n60' href='#n60'>60</a>
<a id='n61' href='#n61'>61</a>
<a id='n62' href='#n62'>62</a>
<a id='n63' href='#n63'>63</a>
<a id='n64' href='#n64'>64</a>
<a id='n65' href='#n65'>65</a>
<a id='n66' href='#n66'>66</a>
<a id='n67' href='#n67'>67</a>
<a id='n68' href='#n68'>68</a>
<a id='n69' href='#n69'>69</a>
<a id='n70' href='#n70'>70</a>
<a id='n71' href='#n71'>71</a>
<a id='n72' href='#n72'>72</a>
<a id='n73' href='#n73'>73</a>
<a id='n74' href='#n74'>74</a>
<a id='n75' href='#n75'>75</a>
<a id='n76' href='#n76'>76</a>
<a id='n77' href='#n77'>77</a>
<a id='n78' href='#n78'>78</a>
<a id='n79' href='#n79'>79</a>
<a id='n80' href='#n80'>80</a>
<a id='n81' href='#n81'>81</a>
<a id='n82' href='#n82'>82</a>
<a id='n83' href='#n83'>83</a>
<a id='n84' href='#n84'>84</a>
<a id='n85' href='#n85'>85</a>
<a id='n86' href='#n86'>86</a>
<a id='n87' href='#n87'>87</a>
<a id='n88' href='#n88'>88</a>
<a id='n89' href='#n89'>89</a>
<a id='n90' href='#n90'>90</a>
<a id='n91' href='#n91'>91</a>
<a id='n92' href='#n92'>92</a>
<a id='n93' href='#n93'>93</a>
<a id='n94' href='#n94'>94</a>
<a id='n95' href='#n95'>95</a>
<a id='n96' href='#n96'>96</a>
<a id='n97' href='#n97'>97</a>
<a id='n98' href='#n98'>98</a>
<a id='n99' href='#n99'>99</a>
<a id='n100' href='#n100'>100</a>
<a id='n101' href='#n101'>101</a>
<a id='n102' href='#n102'>102</a>
</pre></td>
<td class='lines'><pre><code>