From 44741321fcbde01469ba77d6be3ae135ca7899c2 Mon Sep 17 00:00:00 2001 From: ashishk1994 Date: Fri, 3 Feb 2017 02:39:31 +0530 Subject: Unit tests added for openstack/tempest _parse_verification_id method is removed as it is not used anywhere Change-Id: Ia2bc75ffbc2527b04cbe2428e2a3822803bde215 Signed-off-by: ashishk1994 --- functest/opnfv_tests/openstack/tempest/tempest.py | 5 - .../unit/opnfv_tests/openstack/tempest/__init__.py | 0 .../openstack/tempest/test_conf_utils.py | 92 +++++++ .../opnfv_tests/openstack/tempest/test_tempest.py | 279 +++++++++++++++++++++ run_unit_tests.sh | 2 +- 5 files changed, 372 insertions(+), 6 deletions(-) create mode 100644 functest/tests/unit/opnfv_tests/openstack/tempest/__init__.py create mode 100644 functest/tests/unit/opnfv_tests/openstack/tempest/test_conf_utils.py create mode 100644 functest/tests/unit/opnfv_tests/openstack/tempest/test_tempest.py diff --git a/functest/opnfv_tests/openstack/tempest/tempest.py b/functest/opnfv_tests/openstack/tempest/tempest.py index 4c96500db..ae4eed09b 100644 --- a/functest/opnfv_tests/openstack/tempest/tempest.py +++ b/functest/opnfv_tests/openstack/tempest/tempest.py @@ -160,11 +160,6 @@ class TempestCommon(testcase_base.TestcaseBase): result_file.write(str(cases_line) + '\n') result_file.close() - def _parse_verification_id(line): - first_pos = line.index("UUID=") + len("UUID=") - last_pos = line.index(") for deployment") - return line[first_pos:last_pos] - def run_verifier_tests(self): self.OPTION += (" --load-list {}".format(conf_utils.TEMPEST_LIST)) diff --git a/functest/tests/unit/opnfv_tests/openstack/tempest/__init__.py b/functest/tests/unit/opnfv_tests/openstack/tempest/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/functest/tests/unit/opnfv_tests/openstack/tempest/test_conf_utils.py b/functest/tests/unit/opnfv_tests/openstack/tempest/test_conf_utils.py new file mode 100644 index 000000000..6121f4ebb --- /dev/null +++ b/functest/tests/unit/opnfv_tests/openstack/tempest/test_conf_utils.py @@ -0,0 +1,92 @@ +#!/usr/bin/env python + +# All rights reserved. This program and the accompanying materials +# are made available under the terms of the Apache License, Version 2.0 +# which accompanies this distribution, and is available at +# http://www.apache.org/licenses/LICENSE-2.0 + +import logging +import unittest + +import mock + +from functest.opnfv_tests.openstack.tempest import conf_utils +from functest.utils.constants import CONST + + +class OSTempestConfUtilsTesting(unittest.TestCase): + + logging.disable(logging.CRITICAL) + + def test_get_verifier_id_missing_verifier(self): + CONST.tempest_deployment_name = 'test_deploy_name' + with mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.subprocess.Popen') as mock_popen, \ + self.assertRaises(Exception): + mock_stdout = mock.Mock() + attrs = {'stdout.readline.return_value': ''} + mock_stdout.configure_mock(**attrs) + mock_popen.return_value = mock_stdout + conf_utils.get_verifier_id(), + + def test_get_verifier_id_default(self): + CONST.tempest_deployment_name = 'test_deploy_name' + with mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.subprocess.Popen') as mock_popen: + mock_stdout = mock.Mock() + attrs = {'stdout.readline.return_value': 'test_deploy_id'} + mock_stdout.configure_mock(**attrs) + mock_popen.return_value = mock_stdout + + self.assertEqual(conf_utils.get_verifier_id(), + 'test_deploy_id') + + def test_get_verifier_deployment_id_missing_rally(self): + CONST.rally_deployment_name = 'test_rally_deploy_name' + with mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.subprocess.Popen') as mock_popen, \ + self.assertRaises(Exception): + mock_stdout = mock.Mock() + attrs = {'stdout.readline.return_value': ''} + mock_stdout.configure_mock(**attrs) + mock_popen.return_value = mock_stdout + conf_utils.get_verifier_deployment_id(), + + def test_get_verifier_deployment_id_default(self): + CONST.rally_deployment_name = 'test_rally_deploy_name' + with mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.subprocess.Popen') as mock_popen: + mock_stdout = mock.Mock() + attrs = {'stdout.readline.return_value': 'test_deploy_id'} + mock_stdout.configure_mock(**attrs) + mock_popen.return_value = mock_stdout + + self.assertEqual(conf_utils.get_verifier_deployment_id(), + 'test_deploy_id') + + def test_get_verifier_repo_dir_default(self): + with mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.os.path.join', + return_value='test_verifier_repo_dir'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.get_verifier_id') as m: + self.assertEqual(conf_utils.get_verifier_repo_dir(''), + 'test_verifier_repo_dir') + self.assertTrue(m.called) + + def test_get_verifier_deployment_dir_default(self): + with mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.os.path.join', + return_value='test_verifier_repo_dir'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.get_verifier_id') as m1, \ + mock.patch('functest.opnfv_tests.openstack.tempest.' + 'conf_utils.get_verifier_deployment_id') as m2: + self.assertEqual(conf_utils.get_verifier_deployment_dir('', ''), + 'test_verifier_repo_dir') + self.assertTrue(m1.called) + self.assertTrue(m2.called) + + +if __name__ == "__main__": + unittest.main(verbosity=2) diff --git a/functest/tests/unit/opnfv_tests/openstack/tempest/test_tempest.py b/functest/tests/unit/opnfv_tests/openstack/tempest/test_tempest.py new file mode 100644 index 000000000..8ae7b4db3 --- /dev/null +++ b/functest/tests/unit/opnfv_tests/openstack/tempest/test_tempest.py @@ -0,0 +1,279 @@ +#!/usr/bin/env python + +# All rights reserved. This program and the accompanying materials +# are made available under the terms of the Apache License, Version 2.0 +# which accompanies this distribution, and is available at +# http://www.apache.org/licenses/LICENSE-2.0 + +import logging +import unittest + +import mock + +from functest.core import testcase_base +from functest.opnfv_tests.openstack.tempest import tempest +from functest.opnfv_tests.openstack.tempest import conf_utils +from functest.utils.constants import CONST + + +class OSTempestTesting(unittest.TestCase): + + logging.disable(logging.CRITICAL) + + def setUp(self): + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.get_verifier_id', + return_value='test_deploy_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.get_verifier_deployment_id', + return_value='test_deploy_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.get_verifier_repo_dir', + return_value='test_verifier_repo_dir'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.get_verifier_deployment_dir', + return_value='test_verifier_deploy_dir'): + self.tempestcommon = tempest.TempestCommon() + + def test_create_tempest_resources_missing_network_dic(self): + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.get_keystone_client', + return_value=mock.Mock()), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_tenant', + return_value='test_tenant_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_user', + return_value='test_user_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_shared_network_full', + return_value=None), \ + self.assertRaises(Exception) as context: + self.tempestcommon.create_tempest_resources() + msg = 'Failed to create private network' + self.assertTrue(msg in context) + + def test_create_tempest_resources_missing_image(self): + CONST.tempest_use_custom_images = 'test_image' + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.get_keystone_client', + return_value=mock.Mock()), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_tenant', + return_value='test_tenant_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_user', + return_value='test_user_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_shared_network_full', + return_value=mock.Mock()), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.get_or_create_image', + return_value=(mock.Mock(), None)), \ + self.assertRaises(Exception) as context: + self.tempestcommon.create_tempest_resources() + msg = 'Failed to create image' + self.assertTrue(msg in context) + + def test_create_tempest_resources_missing_flavor(self): + CONST.tempest_use_custom_images = 'test_image' + CONST.tempest_use_custom_flavors = 'test_flavour' + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.get_keystone_client', + return_value=mock.Mock()), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_tenant', + return_value='test_tenant_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_user', + return_value='test_user_id'), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.create_shared_network_full', + return_value=mock.Mock()), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.get_or_create_image', + return_value=(mock.Mock(), 'image_id')), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os_utils.get_or_create_flavor', + return_value=(mock.Mock(), None)), \ + self.assertRaises(Exception) as context: + self.tempestcommon.create_tempest_resources() + msg = 'Failed to create flavor' + self.assertTrue(msg in context) + + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.debug') + def test_generate_test_list_defcore_mode(self, mock_logger_debug): + self.tempestcommon.MODE = 'defcore' + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'shutil.copyfile') as m: + self.tempestcommon.generate_test_list('test_verifier_repo_dir') + self.assertTrue(m.called) + + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.error') + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.debug') + def test_generate_test_list_custom_mode_missing_file(self, + mock_logger_debug, + mock_logger_error): + self.tempestcommon.MODE = 'custom' + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.isfile', return_value=False), \ + self.assertRaises(Exception) as context: + msg = "Tempest test list file %s NOT found." + self.tempestcommon.generate_test_list('test_verifier_repo_dir') + self.assertTrue((msg % conf_utils.TEMPEST_CUSTOM) in context) + + def test_generate_test_list_custom_mode_default(self): + self.tempestcommon.MODE = 'custom' + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'shutil.copyfile') as m, \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.isfile', return_value=True): + self.tempestcommon.generate_test_list('test_verifier_repo_dir') + self.assertTrue(m.called) + + def _test_generate_test_list_mode_default(self, mode): + self.tempestcommon.MODE = mode + if self.tempestcommon.MODE == 'smoke': + testr_mode = "smoke" + elif self.tempestcommon.MODE == 'feature_multisite': + testr_mode = "'[Kk]ingbird'" + elif self.tempestcommon.MODE == 'full': + testr_mode = "" + else: + testr_mode = 'tempest.api.' + self.tempestcommon.MODE + conf_utils.TEMPEST_RAW_LIST = 'raw_list' + verifier_repo_dir = 'test_verifier_repo_dir' + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'ft_utils.execute_command') as m: + cmd = ("cd {0};" + "testr list-tests {1} > {2};" + "cd -;".format(verifier_repo_dir, + testr_mode, + conf_utils.TEMPEST_RAW_LIST)) + self.tempestcommon.generate_test_list('test_verifier_repo_dir') + m.assert_any_call(cmd) + + def test_generate_test_list_smoke_mode(self): + self._test_generate_test_list_mode_default('smoke') + + def test_generate_test_list_feature_multisite_mode(self): + self._test_generate_test_list_mode_default('feature_multisite') + + def test_generate_test_list_full_mode(self): + self._test_generate_test_list_mode_default('full') + + def test_parse_verifier_result_missing_verification_uuid(self): + self.tempestcommon.VERIFICATION_ID = '' + with self.assertRaises(Exception): + self.tempestcommon.parse_verifier_result() + + @mock.patch('functest.opnfv_tests.openstack.tempest.tempest.logger.info') + def test_parse_verifier_result_default(self, mock_logger_info): + self.tempestcommon.VERIFICATION_ID = 'test_uuid' + self.tempestcommon.case_name = 'test_case_name' + stdout = ['Testscount||2', 'Success||2', 'Skipped||0', 'Failures||0'] + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'subprocess.Popen') as mock_popen, \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'ft_utils.check_success_rate') as mock_method, \ + mock.patch('__builtin__.open', mock.mock_open()): + mock_stdout = mock.Mock() + attrs = {'stdout': stdout} + mock_stdout.configure_mock(**attrs) + mock_popen.return_value = mock_stdout + + self.tempestcommon.parse_verifier_result() + mock_method.assert_any_call('test_case_name', 100) + + def test_run_missing_create_tempest_dir(self): + ret = testcase_base.TestcaseBase.EX_RUN_ERROR + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.exists', return_value=False), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.makedirs') as mock_os_makedirs, \ + mock.patch.object(self.tempestcommon, 'create_tempest_resources', + return_value=ret): + self.assertEqual(self.tempestcommon.run(), + ret) + self.assertTrue(mock_os_makedirs.called) + + def test_run_missing_configure_tempest(self): + ret = testcase_base.TestcaseBase.EX_RUN_ERROR + ret_ok = testcase_base.TestcaseBase.EX_OK + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.exists', return_value=False), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.makedirs') as mock_os_makedirs, \ + mock.patch.object(self.tempestcommon, + 'create_tempest_resources', + return_value=ret_ok), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.configure_tempest', + return_value=ret): + self.assertEqual(self.tempestcommon.run(), + ret) + self.assertTrue(mock_os_makedirs.called) + + def test_run_missing_generate_test_list(self): + ret = testcase_base.TestcaseBase.EX_RUN_ERROR + ret_ok = testcase_base.TestcaseBase.EX_OK + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.exists', return_value=False), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.makedirs') as mock_os_makedirs, \ + mock.patch.object(self.tempestcommon, 'create_tempest_resources', + return_value=ret_ok), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.configure_tempest', + return_value=ret_ok), \ + mock.patch.object(self.tempestcommon, 'generate_test_list', + return_value=ret): + self.assertEqual(self.tempestcommon.run(), + ret) + self.assertTrue(mock_os_makedirs.called) + + def test_run_missing_apply_tempest_blacklist(self): + ret = testcase_base.TestcaseBase.EX_RUN_ERROR + ret_ok = testcase_base.TestcaseBase.EX_OK + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.exists', return_value=False), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.makedirs') as mock_os_makedirs, \ + mock.patch.object(self.tempestcommon, 'create_tempest_resources', + return_value=ret_ok), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.configure_tempest', + return_value=ret_ok), \ + mock.patch.object(self.tempestcommon, 'generate_test_list', + return_value=ret_ok), \ + mock.patch.object(self.tempestcommon, 'apply_tempest_blacklist', + return_value=ret): + self.assertEqual(self.tempestcommon.run(), + ret) + self.assertTrue(mock_os_makedirs.called) + + def test_run_missing_default_criteria_pass(self): + ret_ok = testcase_base.TestcaseBase.EX_OK + self.tempestcommon.criteria = "PASS" + with mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.path.exists', return_value=False), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'os.makedirs') as mock_os_makedirs, \ + mock.patch.object(self.tempestcommon, 'create_tempest_resources', + return_value=ret_ok), \ + mock.patch('functest.opnfv_tests.openstack.tempest.tempest.' + 'conf_utils.configure_tempest', + return_value=ret_ok), \ + mock.patch.object(self.tempestcommon, 'generate_test_list', + return_value=ret_ok), \ + mock.patch.object(self.tempestcommon, 'apply_tempest_blacklist', + return_value=ret_ok), \ + mock.patch.object(self.tempestcommon, 'run_verifier_tests'), \ + mock.patch.object(self.tempestcommon, 'parse_verifier_result'): + self.assertEqual(self.tempestcommon.run(), + ret_ok) + self.assertTrue(mock_os_makedirs.called) + + +if __name__ == "__main__": + unittest.main(verbosity=2) diff --git a/run_unit_tests.sh b/run_unit_tests.sh index 8e02880a6..7cad227e0 100755 --- a/run_unit_tests.sh +++ b/run_unit_tests.sh @@ -44,7 +44,7 @@ nosetests --with-xunit \ --cover-package=functest.opnfv_tests.sdn.odl.odl \ --cover-package=functest.opnfv_tests.vnf.ims \ --cover-package=functest.utils \ - --cover-package=functest.opnfv_tests.openstack.rally \ + --cover-package=functest.opnfv_tests.openstack \ --cover-xml \ --cover-html \ --log-config=$(pwd)/functest/tests/unit/test_logging.ini \ -- cgit 1.2.3-korg