Refactor resource creation and cleanup in Tempest

Use Snaps to create resources before running a testcase and to clean up
afterwards.
Use Tempest Cleanup utility to clean other resources.

Change-Id: Ic0f69d3bafb60dfb283d18ac507e9f5992e9ae38
Signed-off-by: Martin Kulhavy <martin.kulhavy@nokia.com>

2 files changed, 58 insertions, 7 deletions

diff --git a/functest/opnfv_tests/openstack/refstack_client/refstack_client.py b/functest/opnfv_tests/openstack/refstack_client/refstack_client.py
index 86053ccf3..220b08fe7 100644
--- a/functest/opnfv_tests/openstack/refstack_client/refstack_client.py
+++ b/functest/opnfv_tests/openstack/refstack_client/refstack_client.py
@@ -28,12 +28,13 @@ from functest.opnfv_tests.openstack.refstack_client.tempest_conf \
 from functest.opnfv_tests.openstack.tempest import conf_utils
 from functest.utils.constants import CONST
 import functest.utils.functest_utils as ft_utils
+import functest.utils.openstack_utils as os_utils
 
 # logging configuration """
 LOGGER = logging.getLogger(__name__)
 
 
-class RefstackClient(testcase.OSGCTestCase):
+class RefstackClient(testcase.TestCase):
     """RefstackClient testcase implementation class."""
 
     def __init__(self, **kwargs):
@@ -44,6 +45,7 @@ class RefstackClient(testcase.OSGCTestCase):
         self.conf_path = pkg_resources.resource_filename(
             'functest',
             'opnfv_tests/openstack/refstack_client/refstack_tempest.conf')
+        self.tempestconf = None
         self.functest_test = pkg_resources.resource_filename(
             'functest', 'opnfv_tests')
         self.defcore_list = 'openstack/refstack_client/defcore.txt'
@@ -148,14 +150,16 @@ class RefstackClient(testcase.OSGCTestCase):
             os.makedirs(conf_utils.REFSTACK_RESULTS_DIR)
 
         try:
-            tempestconf = TempestConf()
-            tempestconf.generate_tempestconf()
+            self.tempestconf = TempestConf()
+            self.tempestconf.generate_tempestconf()
             self.run_defcore_default()
             self.parse_refstack_result()
             res = testcase.TestCase.EX_OK
         except Exception:
             LOGGER.exception("Error with run")
             res = testcase.TestCase.EX_RUN_ERROR
+        finally:
+            self.tempestconf.clean()
 
         self.stop_time = time.time()
         return res
@@ -194,6 +198,41 @@ class RefstackClient(testcase.OSGCTestCase):
 
         return res
 
+    def create_snapshot(self):
+        """
+        Run the Tempest cleanup utility to initialize OS state.
+        For details, see https://docs.openstack.org/tempest/latest/cleanup.html
+
+        :return: TestCase.EX_OK
+        """
+        LOGGER.info("Initializing the saved state of the OpenStack deployment")
+
+        # Make sure that the verifier is configured
+        conf_utils.configure_verifier(self.tempestconf.DEPLOYMENT_DIR)
+
+        os_utils.init_tempest_cleanup(
+            self.tempestconf.DEPLOYMENT_DIR, 'tempest.conf',
+            os.path.join(conf_utils.REFSTACK_RESULTS_DIR,
+                         "tempest-cleanup-init.log")
+        )
+
+        return super(RefstackClient, self).create_snapshot()
+
+    def clean(self):
+        """
+        Run the Tempest cleanup utility to delete and destroy OS resources.
+        For details, see https://docs.openstack.org/tempest/latest/cleanup.html
+        """
+        LOGGER.info("Initializing the saved state of the OpenStack deployment")
+
+        os_utils.init_tempest_cleanup(
+            self.tempestconf.DEPLOYMENT_DIR, 'tempest.conf',
+            os.path.join(conf_utils.REFSTACK_RESULTS_DIR,
+                         "tempest-cleanup.log")
+        )
+
+        return super(RefstackClient, self).clean()
+
 
 class RefstackClientParser(object):  # pylint: disable=too-few-public-methods
     """Command line argument parser helper."""
diff --git a/functest/opnfv_tests/openstack/refstack_client/tempest_conf.py b/functest/opnfv_tests/openstack/refstack_client/tempest_conf.py
index 30590b9eb..db7452271 100644
--- a/functest/opnfv_tests/openstack/refstack_client/tempest_conf.py
+++ b/functest/opnfv_tests/openstack/refstack_client/tempest_conf.py
@@ -11,13 +11,15 @@ import pkg_resources
 from functest.opnfv_tests.openstack.tempest import conf_utils
 from functest.utils import openstack_utils
 from functest.utils.constants import CONST
+from functest.opnfv_tests.openstack.tempest.tempest \
+    import TempestResourcesManager
 
 """ logging configuration """
 logger = logging.getLogger(__name__)
 
 
 class TempestConf(object):
-    def __init__(self):
+    def __init__(self, **kwargs):
         self.VERIFIER_ID = conf_utils.get_verifier_id()
         self.VERIFIER_REPO_DIR = conf_utils.get_verifier_repo_dir(
             self.VERIFIER_ID)
@@ -27,15 +29,22 @@ class TempestConf(object):
         self.confpath = pkg_resources.resource_filename(
             'functest',
             'opnfv_tests/openstack/refstack_client/refstack_tempest.conf')
+        self.resources = TempestResourcesManager(**kwargs)
 
     def generate_tempestconf(self):
         try:
             openstack_utils.source_credentials(
                 CONST.__getattribute__('openstack_creds'))
-            img_flavor_dict = conf_utils.create_tempest_resources(
-                use_custom_images=True, use_custom_flavors=True)
+            resources = self.resources.create(create_project=True,
+                                              use_custom_images=True,
+                                              use_custom_flavors=True)
             conf_utils.configure_tempest_defcore(
-                self.DEPLOYMENT_DIR, img_flavor_dict)
+                self.DEPLOYMENT_DIR,
+                image_id=resources.get("image_id"),
+                flavor_id=resources.get("flavor_id"),
+                image_id_alt=resources.get("image_id_alt"),
+                flavor_id_alt=resources.get("flavor_id_alt"),
+                tenant_id=resources.get("project_id"))
         except Exception as e:
             logger.error("error with generating refstack client "
                          "reference tempest conf file: %s", e)
@@ -48,6 +57,9 @@ class TempestConf(object):
         except Exception as e:
             logger.error('Error with run: %s', e)
 
+    def clean(self):
+        self.resources.cleanup()
+
 
 def main():
     logging.basicConfig()