From 2aa78bdb5b21ac54b2f1183001c7466e59952c29 Mon Sep 17 00:00:00 2001 From: Cédric Ollivier Date: Wed, 12 Oct 2016 15:07:03 +0200 Subject: Use importlib to load testcases MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It modifies run_tests.py to dynamically execute testcases and then removes the test condition about odl. It also induces that the modules and the related classes must be defined in ci/testcases.yaml. JIRA: FUNCTEST-353 Change-Id: I6ad67b70624aac6bf805c9bde4dfef7c9fbd5c00 Signed-off-by: Cédric Ollivier --- ci/run_tests.py | 40 +++++++++++++++++++++++++++++++++------- ci/testcases.yaml | 3 +++ 2 files changed, 36 insertions(+), 7 deletions(-) (limited to 'ci') diff --git a/ci/run_tests.py b/ci/run_tests.py index 834a29bf..f30062f7 100755 --- a/ci/run_tests.py +++ b/ci/run_tests.py @@ -9,6 +9,7 @@ # import datetime +import importlib import os import re import sys @@ -23,7 +24,6 @@ import functest.utils.functest_utils as ft_utils import functest.utils.openstack_clean as os_clean import functest.utils.openstack_snapshot as os_snapshot import functest.utils.openstack_utils as os_utils -import functest.testcases.Controllers.ODL.OpenDaylightTesting as odl_test parser = argparse.ArgumentParser() @@ -84,6 +84,19 @@ def update_test_info(test_name, result, duration): "duration": duration}) +def get_run_dict_if_defined(testname): + try: + dict = ft_utils.get_dict_by_test(testname) + if not dict: + logger.error("Cannot get {}'s config options".format(testname)) + elif 'run' in dict: + return dict['run'] + return None + except Exception: + logger.exception("Cannot get {}'s config options".format(testname)) + return None + + def run_test(test, tier_name): global OVERALL_RESULT, EXECUTED_TEST_CASES result_str = "PASS" @@ -102,14 +115,27 @@ def run_test(test, tier_name): if REPORT_FLAG: flags += " -r" - if test_name == 'odl': - odl = odl_test.ODLTestCases() - result = odl.run() - if result == TestCasesBase.TestCasesBase.EX_OK and REPORT_FLAG: - result = odl.push_to_db() + result = TestCasesBase.TestCasesBase.EX_RUN_ERROR + run_dict = get_run_dict_if_defined(test_name) + if run_dict: + try: + module = importlib.import_module(run_dict['module']) + cls = getattr(module, run_dict['class']) + test_case = cls() + result = test_case.run() + if result == TestCasesBase.TestCasesBase.EX_OK and REPORT_FLAG: + result = test_case.push_to_db() + except ImportError: + logger.exception("Cannot import module {}".format( + run_dict['module'])) + except AttributeError: + logger.exception("Cannot get class {}".format( + run_dict['class'])) else: cmd = ("%s%s" % (EXEC_SCRIPT, flags)) - logger.debug("Executing command '%s'" % cmd) + logger.info("Executing command {} because {} " + "doesn't implement the new framework".format( + cmd, test_name)) result = ft_utils.execute_command(cmd) if CLEAN_FLAG: diff --git a/ci/testcases.yaml b/ci/testcases.yaml index 02b69ec8..22509e61 100644 --- a/ci/testcases.yaml +++ b/ci/testcases.yaml @@ -92,6 +92,9 @@ tiers: dependencies: installer: '' scenario: 'odl' + run: + module: 'functest.testcases.Controllers.ODL.OpenDaylightTesting' + class: 'ODLTestCases' - name: onos -- cgit 1.2.3-korg