From a1c07b7eaf67cbbbf174babddecb6b112c08bc84 Mon Sep 17 00:00:00 2001 From: Cédric Ollivier Date: Fri, 21 Jan 2022 11:08:50 +0100 Subject: Protect if detail is returned as None MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It occured when running ansible. Change-Id: I908270fdb76fbc3bdf60787b189cdbc29c41b52b Signed-off-by: Cédric Ollivier (cherry picked from commit 769898458263b7f138c7ffc9126c376781fa71d4) --- xtesting/core/ansible.py | 2 +- xtesting/core/testcase.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xtesting/core/ansible.py b/xtesting/core/ansible.py index 7ccace9f..fa7b533c 100644 --- a/xtesting/core/ansible.py +++ b/xtesting/core/ansible.py @@ -58,7 +58,7 @@ class Ansible(testcase.TestCase): kwargs["quiet"] = True kwargs["artifact_dir"] = self.res_dir runner = ansible_runner.run(**kwargs) - self.details = runner.stats + self.details = runner.stats or {} if runner.rc == 0: self.result = 100 status = self.EX_OK diff --git a/xtesting/core/testcase.py b/xtesting/core/testcase.py index f7814f72..179a5684 100644 --- a/xtesting/core/testcase.py +++ b/xtesting/core/testcase.py @@ -302,6 +302,8 @@ class TestCase(metaclass=abc.ABCMeta): path = urlparse(dst_s3_url).path.strip("/") dst_http_url = os.environ["HTTP_DST_URL"] output_str = "\n" + # protects if test cases return details as None + self.details = self.details or {} self.details["links"] = [] for log_file in [self.output_log_name, self.output_debug_log_name]: if os.path.exists(os.path.join(self.dir_results, log_file)): -- cgit 1.2.3-korg