From 644dc6a6cd8c4a309352a2b2602d757f4acbf63b Mon Sep 17 00:00:00 2001 From: Alexandru Avadanii Date: Sat, 14 Oct 2017 22:47:45 +0200 Subject: states: Break on error, retry states up to 5 times While applying scenario states, break on error, and retry failed state up to 5 times. Apply the same behavior for `salt.sh`. Add new deploy parameter, '-D', backed up by 'CI_DEBUG' env var, which gates deploy sh scripts logging (set -x). Also extend '-f' deploy parameter, allowing it to be specified more than once; the first occurence will skip infra VM creation, but still sync reclass & other config from local repo, while a second occurence will also disable config sync. To prevent glusterfs client state from failing due to non-existent nova user/group, move it after nova:compute's nova state is applied. Change-Id: I234e126e16be0e133d878957bd88fed946955de8 Signed-off-by: Alexandru Avadanii (cherry picked from commit 23f9ef727310a8ef449372313785241df6557559) --- mcp/scripts/create-config-drive.sh | 4 +++- mcp/scripts/globals.sh | 3 ++- mcp/scripts/lib.sh | 5 +++-- mcp/scripts/log.sh | 8 +++++--- mcp/scripts/salt.sh | 12 +++++++----- 5 files changed, 20 insertions(+), 12 deletions(-) (limited to 'mcp/scripts') diff --git a/mcp/scripts/create-config-drive.sh b/mcp/scripts/create-config-drive.sh index 51e38c60d..4b22b27ae 100755 --- a/mcp/scripts/create-config-drive.sh +++ b/mcp/scripts/create-config-drive.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e ############################################################################## # Copyright (c) 2017 Mirantis Inc. and others. # All rights reserved. This program and the accompanying materials @@ -12,6 +12,8 @@ # (using the -k/--ssh-key option) and a user-data blog (using the # -u/--user-data option). +CI_DEBUG=${CI_DEBUG:-0}; [[ "${CI_DEBUG}" =~ (false|0) ]] || set -x + usage () { echo "usage: ${0##*/}: [--ssh-key ] [--vendor-data ] [--user-data ] [--hostname ] " } diff --git a/mcp/scripts/globals.sh b/mcp/scripts/globals.sh index 6dabe65fe..ce4f9ffe9 100644 --- a/mcp/scripts/globals.sh +++ b/mcp/scripts/globals.sh @@ -1,4 +1,4 @@ -#!/bin/bash -ex +#!/bin/bash -e ############################################################################## # Copyright (c) 2017 Ericsson AB, Mirantis Inc., Enea AB and others. # All rights reserved. This program and the accompanying materials @@ -8,6 +8,7 @@ ############################################################################## # Global variables +export CI_DEBUG=${CI_DEBUG:-0}; [[ "${CI_DEBUG}" =~ (false|0) ]] || set -x export SSH_KEY=${SSH_KEY:-"/var/lib/opnfv/mcp.rsa"} export SALT_MASTER=${INSTALLER_IP:-10.20.0.2} export SALT_MASTER_USER=${SALT_MASTER_USER:-ubuntu} diff --git a/mcp/scripts/lib.sh b/mcp/scripts/lib.sh index 7449a2172..da129a7da 100644 --- a/mcp/scripts/lib.sh +++ b/mcp/scripts/lib.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e ############################################################################## # Copyright (c) 2017 Mirantis Inc., Enea AB and others. # All rights reserved. This program and the accompanying materials @@ -198,7 +198,8 @@ function wait_for { # shellcheck disable=SC2034 for attempt in $(seq "${total_attempts}"); do # shellcheck disable=SC2015 - eval "${cmdstr}" && break || true + eval "${cmdstr}" && return 0 || true echo -n '.'; sleep "${sleep_time}" done + return 1 } diff --git a/mcp/scripts/log.sh b/mcp/scripts/log.sh index 8c4bf3ef5..8bfd0d553 100755 --- a/mcp/scripts/log.sh +++ b/mcp/scripts/log.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e ############################################################################## # Copyright (c) 2017 Mirantis Inc., Enea AB and others. # All rights reserved. This program and the accompanying materials @@ -10,12 +10,14 @@ # Collect /var/log from all cluster nodes via Salt Master # +# shellcheck disable=SC1090 +[ -n "${SSH_OPTS}" ] || source "$(dirname "${BASH_SOURCE[0]}")/globals.sh" + +CI_DEBUG=${CI_DEBUG:-0}; [[ "${CI_DEBUG}" =~ (false|0) ]] || set -x DEPLOY_LOG=$1 OPNFV_TMP_LOG="opnfv_fuel_logs" [ -n "${DEPLOY_LOG}" ] || exit 0 -# shellcheck disable=SC1090 -[ -n "${SSH_OPTS}" ] || source "$(dirname "${BASH_SOURCE[0]}")/globals.sh" # ssh to cfg01 # shellcheck disable=SC2086,2087 diff --git a/mcp/scripts/salt.sh b/mcp/scripts/salt.sh index df0ef70fb..3bb17f0cd 100755 --- a/mcp/scripts/salt.sh +++ b/mcp/scripts/salt.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/bash -e ############################################################################## # Copyright (c) 2017 Mirantis Inc., Enea AB and others. # All rights reserved. This program and the accompanying materials @@ -10,6 +10,7 @@ # Deploy Salt Master # +CI_DEBUG=${CI_DEBUG:-0}; [[ "${CI_DEBUG}" =~ (false|0) ]] || set -x F_GIT_ROOT=$(git rev-parse --show-toplevel) OPNFV_TMP_DIR="/home/${SALT_MASTER_USER}/fuel" OPNFV_FUEL_DIR="/root/fuel" @@ -37,14 +38,15 @@ ssh ${SSH_OPTS} "${SSH_SALT}" bash -s -e << SALT_INSTALL_END echo ' done' mkdir -p /srv/salt /usr/share/salt-formulas/reclass + rm -rf ${OPNFV_FUEL_DIR} mv ${OPNFV_TMP_DIR} ${OPNFV_FUEL_DIR} && chown -R root.root ${OPNFV_FUEL_DIR} - ln -s ${OPNFV_FUEL_DIR}/mcp/reclass /srv/salt/reclass - ln -s ${OPNFV_FUEL_DIR}/mcp/deploy/scripts /srv/salt/scripts - cd /srv/salt/${OPNFV_RDIR} && ln -s "\$(uname -i)" arch + ln -sf ${OPNFV_FUEL_DIR}/mcp/reclass /srv/salt + ln -sf ${OPNFV_FUEL_DIR}/mcp/deploy/scripts /srv/salt + cd /srv/salt/${OPNFV_RDIR} && rm -f arch && ln -sf "\$(uname -i)" arch cp -r ${OPNFV_FUEL_DIR}/mcp/metadata/service /usr/share/salt-formulas/reclass cd /srv/salt/reclass/classes/service && \ - ln -s /usr/share/salt-formulas/reclass/service/opendaylight + ln -sf /usr/share/salt-formulas/reclass/service/opendaylight cd ${OPNFV_FUEL_DIR}/mcp/patches && ./patch.sh patches.list reclass cd /srv/salt/scripts -- cgit 1.2.3-korg