summaryrefslogtreecommitdiffstats
path: root/dovetail
diff options
context:
space:
mode:
authorxudan <xudan16@huawei.com>2019-05-17 04:13:30 -0400
committerDan Xu <xudan16@huawei.com>2019-06-10 03:24:16 +0000
commitfe1a78666f215a568866c4b5eb28c8feda0ad278 (patch)
treeb2c93c3f7f3f28b1d91bcb5247fc2b0e4b6d715c /dovetail
parentdc5264ec9b19a8673204af11dbba68bdb50cfde2 (diff)
Bugfix: Fix Dovetail 2 bugs found with CI results
There are 2 bugs found with CI results of functest.tempest.neutron_tempest_plugin_api and all HA test cases. Yardtsick conf file does't mapping the keyfile to Yardstick container, so all HA test cases got SSHERROR. Also remove some useless debug msg to make dovetail.log more concise. Change-Id: I63c12d1b91ed5f8f8a893689384685ca9215f367 Signed-off-by: xudan <xudan16@huawei.com>
Diffstat (limited to 'dovetail')
-rw-r--r--dovetail/report.py2
-rw-r--r--dovetail/testcase.py4
-rw-r--r--dovetail/tests/unit/test_report.py10
-rw-r--r--dovetail/tests/unit/test_testcase.py7
4 files changed, 2 insertions, 21 deletions
diff --git a/dovetail/report.py b/dovetail/report.py
index 65c41484..864f1165 100644
--- a/dovetail/report.py
+++ b/dovetail/report.py
@@ -138,7 +138,6 @@ class Report(object):
'result': testcase.sub_testcase_passed(sub_test)
})
report_obj['testcases_list'].append(testcase_inreport)
- self.logger.debug(json.dumps(report_obj))
return report_obj
def generate(self, testcase_list, duration):
@@ -621,7 +620,6 @@ class FunctestChecker(object):
testcase_passed = 'PASS'
for sub_testcase in sub_testcase_list:
- self.logger.debug('Check sub_testcase: {}'.format(sub_testcase))
try:
if self.get_sub_testcase(sub_testcase,
db_result['details']['success']):
diff --git a/dovetail/testcase.py b/dovetail/testcase.py
index b6f54fa7..279c6ba0 100644
--- a/dovetail/testcase.py
+++ b/dovetail/testcase.py
@@ -77,8 +77,6 @@ class Testcase(object):
def sub_testcase_passed(self, name, passed=None):
if passed is not None:
- self.logger.debug(
- 'sub_testcase_passed: {} {}'.format(name, passed))
self.sub_testcase_status[name] = passed
return self.sub_testcase_status[name]
@@ -145,8 +143,6 @@ class Testcase(object):
try:
with open(test_list, 'w+') as src_file:
for sub_test in self.sub_testcase():
- self.logger.debug(
- 'Save test cases {}'.format(sub_test))
src_file.write(sub_test + '\n')
self.logger.debug('Save test cases to {}'.format(test_list))
return test_list
diff --git a/dovetail/tests/unit/test_report.py b/dovetail/tests/unit/test_report.py
index 4840f2b5..849b31d8 100644
--- a/dovetail/tests/unit/test_report.py
+++ b/dovetail/tests/unit/test_report.py
@@ -1440,16 +1440,6 @@ class ReportTesting(unittest.TestCase):
checker.check(testcase_obj, db_result)
testcase_obj.sub_testcase.assert_called_once_with()
- logger_obj.debug.assert_has_calls([
- call('Check sub_testcase: subt_a'),
- call('Check sub_testcase: subt_b'),
- call('Check sub_testcase: subt_c'),
- call('Check sub_testcase: subt_d')])
- testcase_obj.sub_testcase_passed.assert_has_calls([
- call('subt_a', 'PASS'),
- call('subt_b', 'SKIP'),
- call('subt_c', 'FAIL'),
- call('subt_d', 'FAIL')])
testcase_obj.passed.assert_has_calls([call('PASS'), call('FAIL')])
@patch('dovetail.report.dt_logger')
diff --git a/dovetail/tests/unit/test_testcase.py b/dovetail/tests/unit/test_testcase.py
index b915556c..06a23025 100644
--- a/dovetail/tests/unit/test_testcase.py
+++ b/dovetail/tests/unit/test_testcase.py
@@ -145,8 +145,6 @@ class TestcaseTesting(unittest.TestCase):
result = testcase.sub_testcase_passed('name', 'passed')
- logger_obj.debug.assert_called_once_with(
- 'sub_testcase_passed: name passed')
self.assertEquals('passed', result)
def test_validate_type(self):
@@ -265,9 +263,8 @@ class TestcaseTesting(unittest.TestCase):
mock_path.join.assert_called_once_with('value', 'tempest_custom.txt')
mock_open.assert_called_once_with(file_path, 'w+')
file_obj.write.assert_called_once_with(sub_test + '\n')
- logger_obj.debug.assert_has_calls([
- call('Save test cases {}'.format(sub_test)),
- call('Save test cases to {}'.format(file_path))])
+ logger_obj.debug.assert_called_once_with(
+ 'Save test cases to {}'.format(file_path))
self.assertEquals(file_path, result)
@patch('__builtin__.open')