From 0f762e556ea7b2393f56ca7fb8e06f66f99880aa Mon Sep 17 00:00:00 2001 From: Stanislaw Kardach Date: Tue, 29 Mar 2016 15:06:02 +0200 Subject: Clean up and fix Libvirt and Ceph [ Stanislaw Kardach ] * Fix upload_cirros timeout * Workaround for default video device in nova * Fix syntax and increase TestVM's RAM requirements [ Alexandru Avadanii ] * Cleanup: Obsolete SEPARATE_IMAGES. * Nova libvirt drv: arm64: Update console default. * fuel{,-main}: Cleanup obsolete patches. * nova: Fix inject for direct boot with part table. See https://bugs.launchpad.net/nova/+bug/1290455 for full bug description. For now, we detect direct kernel boot with a partition table inside disk image by passing target_partition when root kernel arg points to a partition (instead of the whole disk). * Drop obsolete/done TODO entries. * Nova: Fix os cmd line parsing for list case. * ceph: Fix obsolete XFS mount param. * Fix out-of-order embedded patch hunks. Signed-off-by: Stanislaw Kardach Signed-off-by: Alexandru Avadanii --- ...eph-Fix-obsolete-XFS-mount-param-delaylog.patch | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 patches/fuel-library/0011-ceph-Fix-obsolete-XFS-mount-param-delaylog.patch (limited to 'patches/fuel-library/0011-ceph-Fix-obsolete-XFS-mount-param-delaylog.patch') diff --git a/patches/fuel-library/0011-ceph-Fix-obsolete-XFS-mount-param-delaylog.patch b/patches/fuel-library/0011-ceph-Fix-obsolete-XFS-mount-param-delaylog.patch new file mode 100644 index 00000000..0d13efeb --- /dev/null +++ b/patches/fuel-library/0011-ceph-Fix-obsolete-XFS-mount-param-delaylog.patch @@ -0,0 +1,48 @@ +From: Alexandru Avadanii +Date: Sun, 27 Mar 2016 20:32:50 +0200 +Subject: [PATCH] ceph: Fix obsolete XFS mount param "delaylog". + +According to [1], "delaylog" mount arg is now enforced by default, +and passing it will lead to mount failure. + +Trim "delaylog" from default list of xfs mount args and leave it up to +ceph-osd.pp to add this obsoleted arg only for targets running a kernel +older than 4.0. + +[1] https://www.kernel.org/doc/Documentation/filesystems/xfs.txt +--- + deployment/puppet/osnailyfacter/modular/ceph/ceph-osd.pp | 7 +++++++ + deployment/puppet/osnailyfacter/modular/globals/globals.pp | 2 +- + 2 files changed, 8 insertions(+), 1 deletion(-) + +diff --git a/deployment/puppet/osnailyfacter/modular/ceph/ceph-osd.pp b/deployment/puppet/osnailyfacter/modular/ceph/ceph-osd.pp +index f7da80e..22aab33 100644 +--- a/deployment/puppet/osnailyfacter/modular/ceph/ceph-osd.pp ++++ b/deployment/puppet/osnailyfacter/modular/ceph/ceph-osd.pp +@@ -50,6 +50,13 @@ class {'ceph': + } + + if $ceph_tuning_settings != {} { ++ if versioncmp($::kernelmajversion, '4.0') < 0 { ++ # FIXME(armband): XFS mount opt delaylog is deprecated in kernels >=4.0. ++ $ceph_tuning_settings['osd_mount_options_xfs'] = join([ ++ $ceph_tuning_settings['osd_mount_options_xfs'], ++ 'delaylog' ++ ], ',') ++ } + ceph_conf { + 'global/debug_default' : value => $debug; + 'global/max_open_files' : value => $ceph_tuning_settings['max_open_files']; +diff --git a/deployment/puppet/osnailyfacter/modular/globals/globals.pp b/deployment/puppet/osnailyfacter/modular/globals/globals.pp +index 268a5b1..69aed7b 100644 +--- a/deployment/puppet/osnailyfacter/modular/globals/globals.pp ++++ b/deployment/puppet/osnailyfacter/modular/globals/globals.pp +@@ -123,7 +123,7 @@ if ($storage_hash['volumes_ceph'] or $storage_hash['images_ceph'] or $storage_ha + $ceph_tuning_settings = { + 'max_open_files' => pick($storage_tuning_settings['max_open_files'], '131072'), + 'osd_mkfs_type' => pick($storage_tuning_settings['osd_mkfs_type'], 'xfs'), +- 'osd_mount_options_xfs' => pick($storage_tuning_settings['osd_mount_options_xfs'], 'rw,relatime,inode64,logbsize=256k,delaylog,allocsize=4M'), ++ 'osd_mount_options_xfs' => pick($storage_tuning_settings['osd_mount_options_xfs'], 'rw,relatime,inode64,logbsize=256k,allocsize=4M'), + 'osd_op_threads' => pick($storage_tuning_settings['osd_op_threads'], '20'), + 'filestore_queue_max_ops' => pick($storage_tuning_settings['filestore_queue_max_ops'], '500'), + 'filestore_queue_committing_max_ops' => pick($storage_tuning_settings['filestore_queue_committing_max_ops'], '5000'), -- cgit 1.2.3-korg