aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-07-12Updated armbandStefan K. Berg1-0/+0
Project: fuel d4ae056501ed0778a19beb6f207c00439f95cff3 Aligning machine type over Ubuntu and Centos We have previously used "pc-1.0" as the qemu-kvm machine definition for virtual Fuel deploys. On Ubuntu this points to: pc-1.0 Standard PC (i440FX + PIIX, 1996) On CentOS 7 this machine definition does not exist, but there's a match in "pc": pc RHEL 7.0.0 PC (i440FX + PIIX, 1996) (alias of pc-i440fx-rhel7.0.0 So, finally, pc is also in Ubuntu: pc Ubuntu 14.04 PC (i440FX + PIIX, 1996) (alias of pc-i440fx-trusty) This change is about exploring whether moving to "pc" will make the auto deploy work on both platforms with the "pc" machine type. What still needs to be done in CentOS is to create a symlink from /usr/libexec/qemu-kvm and /usr/bin/kvm though. Change-Id: I1cce52a21075950cb59b75709b12d724d759e3e6 Signed-off-by: Stefan K. Berg <stefan.k.berg@ericsson.com>
2016-07-12Merge "Fuel VM: set virtio cache to writeback"Alexandru Avadanii1-1/+1
2016-07-12Merge "iptables: Move SSH rules to post-scripts."Alexandru Avadanii2-3/+48
2016-07-12Fuel VM: set virtio cache to writebackJosep Puigdemont1-1/+1
Change-Id: Icbbba0bee68a8fe9de76dbf3c339e01da43fb3a2 Signed-off-by: Josep Puigdemont <josep.puigdemont@enea.com>
2016-07-12iptables: Move SSH rules to post-scripts.Alexandru Avadanii2-3/+48
Previous change [1] introduced the addition of an iptables rule that was supposed to allow SSH access on all ifaces (not only admin iface) when additional ifaces are configured. However, Fuel installer is flushing the rules after transplant adds our SSH config, overwriting it. Move iptables SSH config to post-install section, as standalone script. In order to keep the same behavior, test ifcfg-eth0 (admin interface is expected to be called eth0 by convention) for "DEFROUTE=no" and only whitelist SSH on all ifaces if it matches. [1] https://gerrit.opnfv.org/gerrit/#/c/16571/ Change-Id: I086b75461daa62671cad10494fe34acfd77757ae Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2016-07-12ODL wget: --no-check-certificate for local cache.Alexandru Avadanii1-0/+42
Change-Id: Idbc45b4d1aeddf5450b756d23faf56c95fccc975
2016-07-11Merge "transplant.py: Allow SSH on all interfaces."Alexandru Avadanii1-5/+3
2016-07-11dea_base: use grub-efi-arm64 instead of grub-pc.Josep Puigdemont1-0/+22
Change-Id: Iae462ebe89ff3bc351addd12a8f5cc5ecdef2b11 Signed-off-by: Josep Puigdemont <josep.puigdemont@enea.com>
2016-07-11Updated armbandliang gao1-0/+0
Project: yardstick cd9d1296ab33b0193bfd37e77241291065d9a06b Update fuel plugin 1. update fuel plugin builder 2. change install directory in yardstick plugin Change-Id: Ice560955bb659ca86476b9dd02b3028b853ac01c Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
2016-07-11Updated armbandMaryam Tahhan1-0/+0
Project: vswitchperf dd47e4e2ea55f01235c20bed8e07d69fb51c292e Enable BURST_MODE for l2fwd JIRA: VSPERF-267 This change adds optional burst mode to l2fwd module that makes use of skb->xmit_more API available in Linux Kernel > 3.18 in order to batch transmission of packets out of the NIC, increasing forwarding performance significantly. By default burst mode is disabled. If a value greater than 1 is provided, burst mode is enabled to send that many packets at once. Typical values would be burst=8 or burst=16. Change-Id: I8ef5f86cf73d4cb5a8e4c618a86111ebf411dca8 Signed-off-by: Mesut Ali Ergin <mesut.a.ergin@intel.com> Signed-off-by: Mallesh Koujalagi <malleshx.koujalagi@intel.com>
2016-07-11Updated armbandliang gao1-0/+0
Project: yardstick 567694e4db2d0776db6c115b98f54a4737e52124 Creating Director and related codes. Add a new scenario type 'ScenarioGeneral' that support orchestrating general HA test scenarios. Director, ActionPlayer and RollbackPlayer are uesed to execute the test scenario (or test flow). JIRA: YARDSTICK-288 Change-Id: Ied2ccd4712f3c3efde6771bfa4538c1e9e137c11 Signed-off-by: lihuan <lihuansse@tongji.edu.cn>
2016-07-11Updated armbandkubi1-0/+0
Project: yardstick de26decf97c64b4a9a624d0acbf3882af4916f39 Bug fix:change pod name and extend graph duration Because there were some change with community pod name. We need to change it with new pod name so that all the result could be shown in the grafana JIRA:- Change-Id: I584294a5ead4337160c1ce2fcca8a53901f03a07 Signed-off-by: kubi <jean.gaoliang@huawei.com>
2016-07-08Merge "patches: removed patches upstreamed to fuel@opnfv"Alexandru Avadanii2-192/+0
2016-07-08Updated armbandMichal Skalski1-0/+0
Project: fuel f7f13befab5bf9a585f4f24018fd9561ed61b1ae [BGPVPN] Do not include temporary files in plugin Change-Id: Idd2e2f403a2dd5be44c480e8b493e4281ade1994 Signed-off-by: Michal Skalski <mskalski@mirantis.com>
2016-07-08patches: removed patches upstreamed to fuel@opnfvJosep Puigdemont2-192/+0
Change-Id: I2cd1899d82878dfece22ed546e1ff24d5387e8c1 Signed-off-by: Josep Puigdemont <josep.puigdemont@enea.com>
2016-07-08Updated armbandMichal Skalski1-0/+0
Project: fuel 16ea7e06170ba0bb62a164de5b33f19ccd1b1d12 deploy: ISO rebuild: use -joliet-long names. Armband adds similar files, which tend to have long names and only differ in suffixes (e.g. DEBs for amd64 vs arm64). Previous change [1] fixed ISO build errors, but failed to address the deploy.py ISO rebuild (which modifies and recreates the ISO, calling mkisofs, which complains about clashing file indexes). This works around ISO rebuild error(s) like: "genisoimage: Error: ./ubuntu/pool/main/g/golang-gogoprotobuf/golang-gogoprotobuf\ -dev_0.0~git20150828.0.6cab0cc-1~u14.04+mos1_arm64.deb and ./ubuntu/pool/main/g/golang-gogoprotobuf/golang-gogoprotobuf\ -dev_0.0~git20150828.0.6cab0cc-1~u14.04+mos1_amd64.deb have the same Joliet name" [1] https://gerrit.opnfv.org/gerrit/#/c/14973/ Change-Id: If58a18ba46343a52ce6e9a0a6a0482c1a3079451 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2016-07-08Updated armbandMichal Skalski1-0/+0
Project: fuel 7c600840185d9b454c1995e35a9704db823fb5c6 virtual_fuel: prepare class to allow multiple bridges The VirtualFuel class has now two new methods: del_vm_nics: Deletes all interfaces from the VM. add_vm_nic: Adds a NIC to the VM, attached to the specified bridge. The following method has been deleted: set_vm_nic: implemented with the two new methods Apart from the deleted method, no functionality has been changed. This is just a small but necessary step towards adding support for configuring more than one NIC in the fuel VM. Change-Id: I9f02c8163dfb9768510e78d5d5e77a0bb43306fb Signed-off-by: Josep Puigdemont <josep.puigdemont@enea.com> deploy: add support for multiple bridges deploy.py: Some Fuel VMs may need more than one network interface. To be able to provide that, we now allow the user to specify the "-b" paramter (bridge) multiple times, creating a new NIC for each one of them. The NICs are created in the same order as they are given in the command line. There is no change in behavior from earlier versions, pxebr will still be the default bridge if none is specified in the command line. deploy.sh: To reflect the new capabilities of deploy.py, we introduce the possibility to specify -B more than once in deploy.sh, and honor that when calling deploy.py. We also make it possible to specify a comma separated list of bridges, as in: -B br1,br2. Change-Id: I1a0100f2cfe755ec6adfeedafb391c2357f46f51 Signed-off-by: Josep Puigdemont <josep.puigdemont@enea.com>
2016-07-08Updated armbandMartin Klozik1-0/+0
Project: vswitchperf 64823f173b4fae6921bfde642fb68eac55a470ea yardstick: Documentation and YAML testcase definitions Yardstick supports execution of vsperf specific testcases. These testcases are specified by YAML files located inside yardstick/tests directory. Documentation describing yardstick usage and execution of vsperf testcases is part of the userguide. JIRA: VSPERF-288 Change-Id: I5a575d28d344e0f3e0a1c8434e2f3231fd312d31 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-07-08Updated armbandkubi1-0/+0
Project: yardstick f5acf5d40684080f1633a3c4eafebfe5e6ab69b1 bug fix for huawei-pod2 Since TC027 depends on specific pod configure, so it only should be run at huawei-pod1 JIRA:- Change-Id: Ib85daae64ce97cad907dbaa8309c80cf4f0153b5 Signed-off-by: kubi <jean.gaoliang@huawei.com>
2016-07-08Updated armbandMichal Skalski1-0/+0
Project: fuel f59b4e0786f11e2799990beeaf0e4a148c3572af Point to newer commit in ODL plugin repo Use small fix for setting ovsdb managers. Change-Id: Ie405d4a2db59ea490ff0a690bb310c0c74d8de79 Signed-off-by: Michal Skalski <mskalski@mirantis.com>
2016-07-08Updated armbandliang gao1-0/+0
Project: yardstick 55af4f473d60838b57b14670423717b7f2e901ea Enhence CPUload scenario Enhence CPUload to measure maximum, minimum and average CPU usage. Change-Id: I22d5e56a120ef6bb6ab93094bb053d9999173b32 Signed-off-by: JingLu5 <lvjing5@huawei.com>
2016-07-08Updated armbandliang gao1-0/+0
Project: yardstick 65d32056b14f5f34c2aba186f7ccb3e34c67a9a5 Creating result checker classes JIRA: YARDSTICK-276 Change-Id: I63c4f2c36108e95f5d3b7da42e66cb8c9b16c817 Signed-off-by: lihuan <lihuansse@tongji.edu.cn>
2016-07-08Updated armbandliang gao1-0/+0
Project: yardstick 7b2923df78a0820df9e968ae1909d838c07ebd83 vsperf: Initial integration with VSPERF New scenario class allows to execute vsperf installed inside VM. Vsperf is executed in trafficgen mode. It means, it will only configure and execute traffic by external HW traffic generator based on custom configuration file. After traffic generator stops, then test results will be converted from vsperf CSV format into JSON and passed to yardstick for further processing. Currently, traffic is passed only through external bridge. In the future, test scenarios will launch VNFs and traffic will be properly routed to them. Proper routing can be ensured by OVS flows configuration via setup-script executed during setup phase. Testcase definition yaml files inside vsperf/ directory won't be pushed to the yardstick, but they will be stored inside vsperf repository. They are part of the draft review only to show how it is done. JIRA: VSPERF-288 Change-Id: I13a519ed39091fe89d1a43cc522738044fb3c609 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: <sunshine.wang@huawei.com> Reviewed-by: <lvjing5@huawei.com> Reviewed-by: <jean.gaoliang@huawei.com> Reviewed-by: <david.j.chou@intel.com>
2016-07-08Updated armbandsridharkn1-0/+0
Project: vswitchperf 7cded121ab8291d742ea9d5324f93cae34dc10e5 Spirent-TestCenter: Code Cleanup. Removal of redunant code in testcenter.py. No logic Changes. Cosmetic changes - removing redundant code of 150+ lines. JIRA: VSPERF-308 Change-Id: I4766890cdc9f3d23103b2d2090285361ac4a5197 Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2016-07-08Updated armbandChristian Trautman1-0/+0
Project: vswitchperf 7a16aa0bc7875b5b3fe6385cf99afa076e1e1cb3 rstp-stp: Add basic functions for stp/rstp enable on ovs Add basic functions to enable/disable spanning tree protocols on the bridge. Also adds bridge info function to retrieve other bridge information. JIRA: VSPERF-314 Change-Id: Ic72c5a2a9d16aab1b95428ce37042a5b536481aa Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-07-08Updated armbandChristian Trautman1-0/+0
Project: vswitchperf cead9a3d0571b8afc5ed680475e9bc3ea92c7d79 Namespace_veth: Add funtionality for network namespace, veth ports Adds functionality for network namespaces and veth/peer ports to connect the namespaces. The namespaces are tracked outside of default Linux namespaces to prevent possible disruption of work outside of VSPerf where a user may create a namespace and the cleanup code deletes it. The cleanup code only removes namespaces and veth ports created inside the testcase. JIRA: VSPERF-310 Change-Id: If8881cafb119f38f052403a1de497e9660187d2e Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-07-08Updated armbandliang gao1-0/+0
Project: yardstick 3cf1c2162d800e4f5a5596bdf54732ba906c95f6 Add Yardstick TC044 TEST CASE JIRA:yardstick-290 Change-Id: I2537f6561221226cf8961a2f8221f039cecf7fe0 Signed-off-by: JingLu5 <lvjing5@huawei.com>
2016-07-08Updated armbandliang gao1-0/+0
Project: yardstick 609e6ea459afc1aff901ecb1cd38c403ef8f8c13 Add test case description and task file for TC045 JIRA: YARDSTICK-291 Change-Id: I85081c075fb795ee7839009952e49ad13b9cf2bf Signed-off-by: tjuyinkanglin <14_ykl@tongji.edu.cn>
2016-07-08Updated armbandliang gao1-0/+0
Project: yardstick 4d78a2c02653f4918b55e0becad9094518e1afc3 Add fuel test suite This file is used for verifing yardstick in fuel integration. Change-Id: Ied9f714763f974af5a3abd953f66c966f196c4ec Signed-off-by: JingLu5 <lvjing5@huawei.com>
2016-07-07transplant.py: Allow SSH on all interfaces.Alexandru Avadanii1-5/+3
Previously (in Fuel 8.0), SSH used to listen only on 10.20.0.2 (admin interface), which required editing sshd_config and restarting SSH server for allowing SSH connections over the public IP on eth1 (just an example, which corresponds to Armband PODs use cases). In Fuel 9.0, SSH server on Fuel Master listens on all ifaces, but connections are filtered by iptables. This change piggy-backs on a previous Armband addition that allows transplant.py script to configure additional interfaces (e.g. public). In case additional interfaces have been configured by transplant, this change will instruct iptables to accept SSH connections on ANY interface, not only the admin one. Possible improvements: - limit SSH access to admin + interfaces added by transplant instead of ANY; Change-Id: I0923496e1b23f6dc826c8afbbe9805956c2d4b34 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2016-07-07Temporary: HACK: SR-IOV: Fix VNIC filtering.Alexandru Avadanii1-0/+35
FIXME: Revert this when upstream Fuel 9.1 closes bug [1]. [1] https://bugs.launchpad.net/fuel/+bug/1597775 Change-Id: I692b0ef63ee3e035deadef9d4e47b43f4c53e4aa Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2016-07-07Updated armbandliang gao1-0/+0
Project: yardstick e112b517bdca5f685dd250b9b0a7f6a18f4fb6f8 Add zte-pod1 info in Yardstick test cases Grafana page. Change-Id: Ifdfe75c8168f7d5b9d5ec90880237864200ed4cf Signed-off-by: wu.zhihui <wu.zhihui1@zte.com.cn>
2016-07-07Updated armbandliang gao1-0/+0
Project: yardstick 991aaea442d2a36d43871224a7d96a7e7eea6910 fix the ssh bug when run tc043 in CI Change-Id: I93ffe038ee128976db001e4f2ece79366aa3826c Signed-off-by: rexlee8776 <limingjiang@huawei.com>
2016-07-06Backport: dpkg-checkbuilddeps to mk-build-deps.Alexandru Avadanii1-0/+71
For some reason, our docker sandbox builder already has dh-systemd when checking for "fuel-agent" build-deps, and therefore skips adding it as a build dep inside the chroot, leading to debuild fail. Backporte upstream fix for this from [1]. [1] https://review.openstack.org/#/c/325210/ Change-Id: Ieece9b2250bd91e688bd0f203240da5234930558 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2016-07-06Updated armbandMichal Skalski1-0/+0
Project: fuel fdef1b47e7c2fe894b12e1d0976cc101c09939a1 Point to latest commit in bgpvpn plugin repo Currently we use commit before uplift to mitaka. Change-Id: Ie08a548b133aff01cc2457bd74d0fe7a86a18eff Signed-off-by: Michal Skalski <mskalski@mirantis.com>
2016-07-06Updated armbandliang gao1-0/+0
Project: yardstick eacef205efa9289bccbf38d82df07cdc63486d35 Creating a generic opertion Operation class is used to do some work on the target system such as creating a VM instance. JIRA: YARDSTICK-275 Change-Id: Ib62846824b74dcdae51f143bc59fba385cc7d84c Signed-off-by: lihuan <lihuansse@tongji.edu.cn>
2016-07-06Updated armbandliang gao1-0/+0
Project: yardstick 51b902b9d9d7a641357dd615dcd5a5529bffc8bb Add Yardstick TC004 TEST CASE JIRA:yardstick-14 Change-Id: I9ff76265db4677298bf60358a5259f3fb48f24a0 Signed-off-by: JingLu5 <lvjing5@huawei.com>
2016-07-05Merge "[BGPVPN] Enable/add plugin build to ISO."Alexandru Avadanii1-1/+1
2016-07-05Merge "ODL: Rework opnfv-quagga building/packaging."Alexandru Avadanii3-37/+98
2016-07-05[BGPVPN] Enable/add plugin build to ISO.Alexandru Avadanii1-1/+1
Change-Id: I4d01e9f9aeea3b0ab5bcc7fbe6840b8960fff5d9
2016-07-05Updated armbandAlexandru Avadanii1-0/+0
Project: fuel 50ebdb5d193ad7085ac1ba906622ae4cd0dd8f3c [BGPVPN] fpm: Build multiarch DEBs (arch <all>) Update upstream reference to include support for building DEB packages for architecture <all> instead of the native one, since apart from one small hardcoded check on Fedora for java version, most code is arch-independant (python). TODO: Extend check for `uname -m` result for aarch64 and other platforms in <networking_odl/devstack/setup_java.sh>. While at it, make git info variable overrideable, just in case we want to patch this out of upstream tree locally. Change-Id: Ia139c8d957f65bb120dca1727fd4a422e2510ea0 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2016-07-05Updated armbandMichal Skalski1-0/+0
Project: fuel d1466b0f8792bde0a1e39d2071a03d0317e0f7ee Fix ODL deployments Change-Id: Idae02b340d3a64109deeda7ef67574430b928219 Signed-off-by: Michal Skalski <mskalski@mirantis.com>
2016-07-05ODL: Rework opnfv-quagga building/packaging.Alexandru Avadanii3-37/+98
My initial goal was to split the ODL patch in two patches: - leveldb + leveldbjni arm64 support; - opnfv-quagga building/packing for multiple archs (UBUNTU_ARCH); However, due to the design of opnfv-packaging repo, it is easier to: - patch upstream sources to support native arm64 builds (see [1]); - add prebuilt arm64 binaries to output dir in git repo (like amd64), submitted as pull request upstream [2]; Until above OPNFV-QUAGGA changes land upstream or are refactored, rely on forked repository that contains above patches [3] on branch "stable/colorado". opnfv-quagga patch adding UBUNTU_ARCH parsing is more or less there to detect missing DEBs, rather than filter prebuilt DEBs, which for now only cover "amd64 arm64". [1] https://github.com/nikolas-hermanns/opnfv-quagga-packaging/pull/1 [2] https://github.com/nikolas-hermanns/opnfv-quagga-packaging/pull/2 [3] https://github.com/alexandruavadanii/opnfv-quagga-packaging Change-Id: I022c1e82531d82422486f2041c70a3f50b6ca386 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2016-07-05Updated armbandliang gao1-0/+0
Project: yardstick 12f7ee47f39091be7b139f9bc083dbc675099937 SFC Yardstick test Modifications of the SFC Yardstick test The test creates two chains. One chain blocks HTTP the other one blocks SSH. We doublecheck that HTTP works in one but not in the other and the same for SSH. There are some things that must be modified manually as ODL is not yet ready for ovs 2.5.90. Here are the instructions: https://wiki.opnfv.org/display/sfc/Yardstick Change-Id: Ide6588a682f3491ab58c47ee7335205868c109fc Signed-off-by: Manuel Buil <manuel.buil@ericsson.com>
2016-07-05Updated armbandliang gao1-0/+0
Project: yardstick 588631b53537b71330bd21e4f9aebb9de429b2a3 Creating a generic monitor JIRA: YARDSTICK-274 Change-Id: Iac8c525b36b2778767177b17e6107866cc514e40 Signed-off-by: lihuan <lihuansse@tongji.edu.cn>
2016-07-04Updated armbandMichal Skalski1-0/+0
Project: fuel 04f06ae01f621d5d4aea7d59cb030cf01cb4209d Plugin version is required Plugin version is required when plugin configuration is overwritten. Change-Id: I93af002ed5e994c90b9134f8c020a3822e81e42c Signed-off-by: Michal Skalski <mskalski@mirantis.com>
2016-07-04Updated armbandwu.zhihui1-0/+0
Project: fuel 9d297e24981101f99e9c72de9ff4c6c0b69a505f Modify the indent in fuel-odl_0.9.0.yaml. Change-Id: I15bb84c35c075037df23746b75b108e2d7b90ede Signed-off-by: wu.zhihui <wu.zhihui1@zte.com.cn>
2016-07-04Updated armbandJingLu51-0/+0
Project: yardstick d51cbf72b8fb2e5c6acc06248919b1401d09c853 Add support for multiple VMs Verify and add support for multiple target VMs. This is related to further work with SDNVPN project. In the task configration file, use 'target' for specifying one target VM and use 'targets' for specifying multiple target VMs. Change-Id: I682188ef4c2c2c012d5ab00417b69f5b31b87137 Signed-off-by: JingLu5 <lvjing5@huawei.com>
2016-07-01Updated armbandChristian Trautman1-0/+0
Project: vswitchperf 26a7262cee1a2961ed5aa76bd969dddeff8ea472 multi-queue: Add basic multi-queue functionality Adds support for multi-queue using the following config. * VNF = QemuDpdkVhostUser * VSWITCH = OvsDpdkVhost * Guest Loopback as testpmd Adds CPU mask, nbcore, rxq, and txq options for testpmd. Adds option for guest nic multi-queue. Adds option for dpdkvhostuser and dpdk multi-queue enable JIRA: VSPERF-309 Change-Id: I5296fc18b430eace598d8c51620fc27a6c46a65e Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-07-01Updated armbandChristian Trautman1-0/+0
Project: vswitchperf 4bd09fc0c95f89f3041e6a5a66613eb7cd7eaff8 Spirent Support for Continuous Traffic Adding changes for supporting continuous traffic for Spirent Testcenter The changes are as follows: 1. From send_cont_traffic invoke function in testcenter-rfc2544-rest.py 2. In testcenter-rfc2544-rest.py check for the traffic_custom 3. If the traffic_custom is 'cont' do additional configuration on traffic. JIRA: VSPERF-146 Change-Id: Ic963f9f0c2bd013f6e676c9d18b151ae67ff77af Signed-off-by: Sridhar Rao <sridhar.rao@spirent.com>