From 46bf00b967844dc712dfe409e55fc5fe18fa119f Mon Sep 17 00:00:00 2001 From: Tim Rozet Date: Fri, 7 Dec 2018 09:49:21 -0500 Subject: Fix using ODL versions other than oxygen Fixes a bug where oxygen was always being used even if a different ODL version was specified in the deploy settings. Also updates the valid ODL versions with fluorine and neon. JIRA: APEX-648 Change-Id: Ie49c28d1757cd7e57802d67e48904ce04864feaf Signed-off-by: Tim Rozet --- apex/builders/overcloud_builder.py | 5 +++++ apex/common/constants.py | 3 ++- apex/settings/deploy_settings.py | 3 --- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/apex/builders/overcloud_builder.py b/apex/builders/overcloud_builder.py index a74ec252..eab8fb66 100644 --- a/apex/builders/overcloud_builder.py +++ b/apex/builders/overcloud_builder.py @@ -25,7 +25,12 @@ def inject_opendaylight(odl_version, image, tmp_dir, uc_ip, assert odl_version in con.VALID_ODL_VERSIONS # add repo if odl_version == 'master': + # last version in the constants is "master" so select 2nd to last + # odl package version has no "master" version odl_pkg_version = con.VALID_ODL_VERSIONS[-2] + # branch will be used to pull puppet-opendaylight. Since puppet-odl + # does not pull branch until later, we need to use master version of + # that if master ODL version is specified branch = odl_version else: odl_pkg_version = odl_version diff --git a/apex/common/constants.py b/apex/common/constants.py index dbdf70d9..4e48920e 100644 --- a/apex/common/constants.py +++ b/apex/common/constants.py @@ -43,7 +43,8 @@ THT_DOCKER_ENV_DIR = os.path.join(THT_ENV_DIR, 'services') DEFAULT_OS_VERSION = 'master' DEFAULT_ODL_VERSION = 'oxygen' -VALID_ODL_VERSIONS = ['carbon', 'nitrogen', 'oxygen', 'master'] +VALID_ODL_VERSIONS = ['carbon', 'nitrogen', 'oxygen', 'fluorine', + 'neon', 'master'] PUPPET_ODL_URL = 'https://git.opendaylight.org/gerrit/integration/packaging' \ '/puppet-opendaylight' DEBUG_OVERCLOUD_PW = 'opnfvapex' diff --git a/apex/settings/deploy_settings.py b/apex/settings/deploy_settings.py index 00e6d6c0..9f8a6f18 100644 --- a/apex/settings/deploy_settings.py +++ b/apex/settings/deploy_settings.py @@ -129,9 +129,6 @@ class DeploySettings(dict): "Invalid SRIOV interface name: {}".format( self['deploy_options']['sriov'])) - if self['deploy_options']['odl_version'] == 'oxygen': - self['deploy_options']['odl_version'] = 'master' - if 'performance' in deploy_options: if not isinstance(deploy_options['performance'], dict): raise DeploySettingsException("Performance deploy_option" -- cgit 1.2.3-korg