Adds deployment via snapshot

New arguments are added to allow snapshot deployment:
--snapshot, --snap-cache

The previous tripleo-quickstart code has been removed/replaced
with the snapshot option.

Snapshot deployments are supported on CentOS and Fedora, and snapshot
artifacts use a similar caching system as the standard deployment.
Snapshots are produced daily by Apex, and include latest as well as n-1
OpenStack versions. The os-odl-nofeature scenario is used for the
snapshots. Additionally multiple topology verions of Snapshots are
available. The Snapshot pulled at deploy time depends on the
deploy-settings and number of virtual-computes used at deploy time.

Since there is only one network used with snapshot deployments (admin),
there is no reason to pass in network settings for snapshot deployments.
That argument is now optional. Previously we required even in Standard
virtual deployments that the network settings be provided. However that
is also unnecessary, as we can default to the virtual network settings.

Includes minor fix to the tox.ini to allow specifying test cases
to run (useful for developers writing tests). Default behavior of
tox is unchanged.

JIRA: APEX-548

Change-Id: I1e08c4e54eac5aae99921f61ab7f69693ed12b47
Signed-off-by: Tim Rozet <trozet@redhat.com>

1 files changed, 191 insertions, 0 deletions

diff --git a/apex/tests/test_apex_overcloud_node.py b/apex/tests/test_apex_overcloud_node.py
new file mode 100644
index 00000000..4c67b1d8
--- /dev/null
+++ b/apex/tests/test_apex_overcloud_node.py
@@ -0,0 +1,191 @@
+##############################################################################
+# Copyright (c) 2018 Tim Rozet (trozet@redhat.com) (Red Hat)
+#
+# All rights reserved. This program and the accompanying materials
+# are made available under the terms of the Apache License, Version 2.0
+# which accompanies this distribution, and is available at
+# http://www.apache.org/licenses/LICENSE-2.0
+##############################################################################
+
+from libvirt import libvirtError
+from mock import patch
+from mock import MagicMock
+import os
+import unittest
+import urllib.request
+
+from apex.common import exceptions as exc
+from apex.overcloud.node import OvercloudNode
+from apex.settings.deploy_settings import DeploySettings
+from apex.tests.constants import TEST_DUMMY_CONFIG
+
+DUMMY_SNAP_DIR = '/tmp/dummy_cache'
+
+
+class TestSnapshotDeployment(unittest.TestCase):
+    @classmethod
+    def setup_class(cls):
+        """This method is run once for each class before any tests are run"""
+
+    @classmethod
+    def teardown_class(cls):
+        """This method is run once for each class _after_ all tests are run"""
+
+    def setup(self):
+        """This method is run once before _each_ test method is executed"""
+
+    def teardown(self):
+        """This method is run once after _each_ test method is executed"""
+
+    @patch('apex.overcloud.node.OvercloudNode.create')
+    @patch('apex.overcloud.node.os.path.isfile')
+    @patch('apex.overcloud.node.libvirt.open')
+    def test_init(self, mock_libvirt_open, mock_is_file, mock_node_create):
+        mock_is_file.return_value = True
+        OvercloudNode(role='controller', ip='123.123.123.123',
+                      ovs_ctrlrs=None, ovs_mgrs=None,
+                      name='dummy-controller-0', node_xml='dummynode.xml',
+                      disk_img='dummy.qcow2')
+        mock_node_create.assert_called()
+
+    @patch('apex.overcloud.node.OvercloudNode.create')
+    @patch('apex.overcloud.node.libvirt.open')
+    def test_init_invalid_files(self, mock_libvirt_open, mock_node_create):
+        self.assertRaises(exc.OvercloudNodeException,
+                          OvercloudNode, 'controller', '123.123.123',
+                          None, None, 'dummy-controller-0', 'dummynode.xml',
+                          'dummy.qcow2')
+
+    @patch('apex.overcloud.node.shutil.copyfile')
+    @patch('apex.overcloud.node.OvercloudNode.create')
+    @patch('apex.overcloud.node.os.path.isfile')
+    @patch('apex.overcloud.node.libvirt.open')
+    def test_configure_disk(self, mock_libvirt_open, mock_is_file,
+                            mock_node_create, mock_copy):
+        mock_is_file.return_value = True
+        node = OvercloudNode(role='controller', ip='123.123.123.123',
+                             ovs_ctrlrs=None, ovs_mgrs=None,
+                             name='dummy-controller-0',
+                             node_xml='dummynode.xml',
+                             disk_img='dummy.qcow2')
+        conn = mock_libvirt_open.return_value
+        conn.storagePoolLookupByName.return_value.XMLDesc.return_value = """
+        <pool type='dir'>
+          <target>
+            <path>/var/lib/libvirt/images</path>
+          </target>
+        </pool>
+        """
+        node._configure_disk('dummy.qcow2')
+        mock_copy.assert_called()
+        self.assertEqual(node.disk_img, '/var/lib/libvirt/images/dummy.qcow2')
+
+    @patch('apex.overcloud.node.shutil.copyfile')
+    @patch('apex.overcloud.node.OvercloudNode.create')
+    @patch('apex.overcloud.node.os.path.isfile')
+    @patch('apex.overcloud.node.libvirt.open')
+    def test_configure_disk_bad_path(self, mock_libvirt_open, mock_is_file,
+                                     mock_node_create, mock_copy):
+        mock_is_file.return_value = True
+        node = OvercloudNode(role='controller', ip='123.123.123.123',
+                             ovs_ctrlrs=None, ovs_mgrs=None,
+                             name='dummy-controller-0',
+                             node_xml='dummynode.xml',
+                             disk_img='dummy.qcow2')
+        conn = mock_libvirt_open.return_value
+        conn.storagePoolLookupByName.return_value.XMLDesc.return_value = """
+        <pool type='dir'>
+          <target>
+          </target>
+        </pool>
+        """
+        self.assertRaises(exc.OvercloudNodeException,
+                          node._configure_disk, 'dummy.qcow2')
+
+    @patch('apex.overcloud.node.shutil.copyfile')
+    @patch('apex.overcloud.node.OvercloudNode.create')
+    @patch('apex.overcloud.node.os.path.isfile')
+    @patch('apex.overcloud.node.libvirt.open')
+    def test_configure_disk_no_pool(self, mock_libvirt_open, mock_is_file,
+                                    mock_node_create, mock_copy):
+        mock_is_file.return_value = True
+        node = OvercloudNode(role='controller', ip='123.123.123.123',
+                             ovs_ctrlrs=None, ovs_mgrs=None,
+                             name='dummy-controller-0',
+                             node_xml='dummynode.xml',
+                             disk_img='dummy.qcow2')
+        conn = mock_libvirt_open.return_value
+        conn.storagePoolLookupByName.return_value = None
+        self.assertRaises(exc.OvercloudNodeException,
+                          node._configure_disk, 'dummy.qcow2')
+
+    @patch('apex.overcloud.node.distro.linux_distribution')
+    def test_update_xml(self, mock_linux_distro):
+        mock_linux_distro.return_value = ['Fedora']
+        xml_file = os.path.join(TEST_DUMMY_CONFIG, 'baremetal0.xml')
+        with open(xml_file, 'r') as fh:
+            xml = fh.read()
+        new_xml = OvercloudNode._update_xml(
+            xml=xml, disk_path='/dummy/disk/path/blah.qcow2')
+        self.assertIn('/dummy/disk/path/blah.qcow2', new_xml)
+        self.assertIn('/usr/bin/qemu-kvm', new_xml)
+
+    @patch('apex.overcloud.node.distro.linux_distribution')
+    def test_update_xml_no_disk(self, mock_linux_distro):
+        mock_linux_distro.return_value = ['Fedora']
+        xml_file = os.path.join(TEST_DUMMY_CONFIG, 'baremetal0.xml')
+        with open(xml_file, 'r') as fh:
+            xml = fh.read()
+        new_xml = OvercloudNode._update_xml(xml=xml)
+        self.assertIn('/home/images/baremetal0.qcow2', new_xml)
+        self.assertIn('/usr/bin/qemu-kvm', new_xml)
+
+    @patch('apex.overcloud.node.OvercloudNode._update_xml')
+    @patch('apex.overcloud.node.OvercloudNode._configure_disk')
+    @patch('apex.overcloud.node.libvirt.open')
+    @patch('apex.overcloud.node.os.path.isfile')
+    def test_create(self, mock_isfile, mock_libvirt_conn, mock_configure_disk,
+                    mock_update_xml):
+        mock_isfile.return_value = True
+        domain = mock_libvirt_conn.return_value.defineXML.return_value
+        node = OvercloudNode(role='controller', ip='123.123.123.123',
+                             ovs_ctrlrs=None, ovs_mgrs=None,
+                             name='dummy-controller-0',
+                             node_xml=os.path.join(TEST_DUMMY_CONFIG,
+                                                   'baremetal0.xml'),
+                             disk_img='dummy.qcow2')
+        self.assertIs(node.vm, domain)
+
+    @patch('apex.overcloud.node.OvercloudNode._update_xml')
+    @patch('apex.overcloud.node.OvercloudNode._configure_disk')
+    @patch('apex.overcloud.node.libvirt.open')
+    @patch('apex.overcloud.node.os.path.isfile')
+    def test_start(self, mock_isfile, mock_libvirt_conn, mock_configure_disk,
+                   mock_update_xml):
+        mock_isfile.return_value = True
+        domain = mock_libvirt_conn.return_value.defineXML.return_value
+        node = OvercloudNode(role='controller', ip='123.123.123.123',
+                             ovs_ctrlrs=None, ovs_mgrs=None,
+                             name='dummy-controller-0',
+                             node_xml=os.path.join(TEST_DUMMY_CONFIG,
+                                                   'baremetal0.xml'),
+                             disk_img='dummy.qcow2')
+        node.start()
+        domain.create.assert_called()
+
+    @patch('apex.overcloud.node.OvercloudNode._update_xml')
+    @patch('apex.overcloud.node.OvercloudNode._configure_disk')
+    @patch('apex.overcloud.node.libvirt.open')
+    @patch('apex.overcloud.node.os.path.isfile')
+    def test_start_fail(self, mock_isfile, mock_libvirt_conn,
+                        mock_configure_disk, mock_update_xml):
+        mock_isfile.return_value = True
+        domain = mock_libvirt_conn.return_value.defineXML.return_value
+        domain.create.side_effect = libvirtError('blah')
+        node = OvercloudNode(role='controller', ip='123.123.123.123',
+                             ovs_ctrlrs=None, ovs_mgrs=None,
+                             name='dummy-controller-0',
+                             node_xml=os.path.join(TEST_DUMMY_CONFIG,
+                                                   'baremetal0.xml'),
+                             disk_img='dummy.qcow2')
+        self.assertRaises(exc.OvercloudNodeException, node.start)