From b9aab0951835be1acee0e116b0d679c9af1489f4 Mon Sep 17 00:00:00 2001
From: Gael Chamoulaud <gchamoul@redhat.com>
Date: Mon, 21 Sep 2015 15:14:27 +0200
Subject: Make puppet manifests compliant with Puppet 4.x

- https://docs.puppetlabs.com/puppet/3.8/reference/deprecated_language.html
- Temporary disablement of the pupppet-lint autoload layout check
  failing for ringbuilder.pp. A fix for that will be part of an other patch.

Change-Id: I495825641ab12e7c5789c1405649c356c5bb8051
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
---
 puppet/manifests/overcloud_compute.pp | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

(limited to 'puppet/manifests/overcloud_compute.pp')

diff --git a/puppet/manifests/overcloud_compute.pp b/puppet/manifests/overcloud_compute.pp
index 2150bab8..4c927569 100644
--- a/puppet/manifests/overcloud_compute.pp
+++ b/puppet/manifests/overcloud_compute.pp
@@ -13,7 +13,7 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
-include tripleo::packages
+include ::tripleo::packages
 
 create_resources(sysctl::value, hiera('sysctl_settings'), {})
 
@@ -24,14 +24,14 @@ if count(hiera('ntp::servers')) > 0 {
 file { ['/etc/libvirt/qemu/networks/autostart/default.xml',
         '/etc/libvirt/qemu/networks/default.xml']:
   ensure => absent,
-  before => Service['libvirt']
+  before => Service['libvirt'],
 }
 # in case libvirt has been already running before the Puppet run, make
 # sure the default network is destroyed
 exec { 'libvirt-default-net-destroy':
   command => '/usr/bin/virsh net-destroy default',
-  onlyif => '/usr/bin/virsh net-info default | /bin/grep -i "^active:\s*yes"',
-  before => Service['libvirt'],
+  onlyif  => '/usr/bin/virsh net-info default | /bin/grep -i "^active:\s*yes"',
+  before  => Service['libvirt'],
 }
 
 include ::nova
@@ -55,10 +55,10 @@ if $rbd_ephemeral_storage or $rbd_persistent_storage {
 }
 
 if hiera('cinder_enable_nfs_backend', false) {
-  if ($::selinux != "false") {
+  if str2bool($::selinux) {
     selboolean { 'virt_use_nfs':
-        value => on,
-        persistent => true,
+      value      => on,
+      persistent => true,
     } -> Package['nfs-utils']
   }
 
@@ -69,20 +69,20 @@ include ::nova::compute::libvirt
 include ::nova::network::neutron
 include ::neutron
 
-class { 'neutron::plugins::ml2':
+class { '::neutron::plugins::ml2':
   flat_networks        => split(hiera('neutron_flat_networks'), ','),
   tenant_network_types => [hiera('neutron_tenant_network_type')],
 }
 
-class { 'neutron::agents::ml2::ovs':
+class { '::neutron::agents::ml2::ovs':
   bridge_mappings => split(hiera('neutron_bridge_mappings'), ','),
   tunnel_types    => split(hiera('neutron_tunnel_types'), ','),
 }
 
 if 'cisco_n1kv' in hiera('neutron_mechanism_drivers') {
-  class { 'neutron::agents::n1kv_vem':
-    n1kv_source          => hiera('n1kv_vem_source', undef),
-    n1kv_version         => hiera('n1kv_vem_version', undef),
+  class { '::neutron::agents::n1kv_vem':
+    n1kv_source  => hiera('n1kv_vem_source', undef),
+    n1kv_version => hiera('n1kv_vem_version', undef),
   }
 }
 
@@ -97,7 +97,7 @@ snmp::snmpv3_user { $snmpd_user:
   authtype => 'MD5',
   authpass => hiera('snmpd_readonly_user_password'),
 }
-class { 'snmp':
+class { '::snmp':
   agentaddress => ['udp:161','udp6:[::1]:161'],
   snmpd_config => [ join(['rouser ', hiera('snmpd_readonly_user_name')]), 'proc  cron', 'includeAllDisks  10%', 'master agentx', 'trapsink localhost public', 'iquerySecName internalUser', 'rouser internalUser', 'defaultMonitors yes', 'linkUpDownNotifications yes' ],
 }
-- 
cgit 1.2.3-korg