path: root/extraconfig/post_deploy
diff options
authorSteve Baker <sbaker@redhat.com>2015-12-10 14:48:04 +1300
committerSteve Baker <sbaker@redhat.com>2015-12-10 14:48:04 +1300
commit1733d74392b0cc8f3577da68fbb5eb6165802c37 (patch)
tree65f62c228f6e137831353ba84d88e9277bd364d4 /extraconfig/post_deploy
parent2674efae84f6ba808fbaa5f0150825e42a86ba59 (diff)
Set the name property for all deployment resources
There are two reasons the name property should always be set for deployment resources: - The name often shows up in logs, files and API calls, the default derived name is long and unhelpful - Sorting by name determines the merge order of os-apply-config, and the execution order of puppet/shell scripts (note this is different to resource dependency order) so leaving the default name results in an undetermined order which could lead to unpredictable deployment of configs This change simply sets the name to the resource name, but a future change should prepend each name with a run-parts style 2 digit prefix so that the order is explicitly stated. Documentation for extraconfig needs to clearly state what prefix is needed to override which merge/execution order. For existing overcloud stacks, heat currently replaces deployment resources when the name changes, so this change Depends-On: I95037191915ccd32b2efb72203b146897a4edbc9 Change-Id: Ic4bcd56aa65b981275c3d4214588bfc4de63b3b0
Diffstat (limited to 'extraconfig/post_deploy')
1 files changed, 1 insertions, 0 deletions
diff --git a/extraconfig/post_deploy/example.yaml b/extraconfig/post_deploy/example.yaml
index 1d3dca2..f83dff7 100644
--- a/extraconfig/post_deploy/example.yaml
+++ b/extraconfig/post_deploy/example.yaml
@@ -22,6 +22,7 @@ resources:
type: OS::Heat::SoftwareDeployments
+ name: ExtraDeployments
servers: {get_param: servers}
config: {get_resource: ExtraConfig}
actions: ['CREATE'] # Only do this on CREATE