diff options
| author |   Jiri Stransky <jistr@redhat.com> | 2017-06-14 15:24:46 +0200 |
|---|---|---|
| committer | Jiri Stransky <jistr@redhat.com> | 2017-06-14 15:58:55 +0200 |
| commit | 248099db8c583f6e80fda24f45db74361b757128 (patch) | |
| tree | 21adb8f419ebf25fd391b460e2b0c426f3d47d46 /docker/services/database/redis.yaml | |
| parent | 0d87942dd78be0456842136479aa7da8de3f0151 (diff) | |
Fix race conditions between containers
In many occasions we had log directory initialization containers
without `detach: false`, which didn't guarantee that they'll finish
before the container depending on them will start using the log
directory.
This is now fixed by moving the initialization container one global
step earlier, so that we can keep the concurrency when creating the
log dirs. (Using `detach: false` makes paunch handle just one
container at a time, and as such it can have negative performance
impact.)
For services which have their container(s) starting in step_1,
initialization cannot be moved to an earlier step, so the solution
here was to just add `detach: false`.
As a minor related change, cinder DB sync container now mounts the log
directory from host to put cinder-manage.log into the expected
location.
Change-Id: I1340de4f68dd32c2412d9385cf3a8ca202b48556
Diffstat (limited to 'docker/services/database/redis.yaml')
| -rw-r--r-- | docker/services/database/redis.yaml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/docker/services/database/redis.yaml b/docker/services/database/redis.yaml index 9e84dd5f..9d0d30c8 100644 --- a/docker/services/database/redis.yaml +++ b/docker/services/database/redis.yaml @@ -79,6 +79,7 @@ outputs: step_1: redis_init_logs: start_order: 0 + detach: false image: *redis_image privileged: false user: root @@ -86,6 +87,7 @@ outputs: - /var/log/containers/redis:/var/log/redis command: ['/bin/bash', '-c', 'chown -R redis:redis /var/log/redis'] redis: + start_order: 1 image: *redis_image net: host privileged: false |