summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCarlos Camacho <ccamacho@redhat.com>2017-01-17 16:44:40 +0100
committerCarlos Camacho <ccamacho@redhat.com>2017-01-18 12:30:15 +0100
commit7efa88bbec6294e59d7334e60dffab02825f8418 (patch)
tree6db22718b48f35b5da415ec85133b3088b1a9155
parent3db59dfd57c41bd5b2df4aafcc4b0d9a4ea55675 (diff)
Check that all templates are using the release alias
Quick verification to check that the release name is used instead the date. Im also adding here all the updated templates required to pass the check and merge this check as soon as possible. Change-Id: Ifdc9ac4a9d0a4872d3e21672c93fc87da2e68a4e
-rw-r--r--puppet/services/cinder-hpelefthand-iscsi.yaml2
-rwxr-xr-xtools/yaml-validate.py4
2 files changed, 5 insertions, 1 deletions
diff --git a/puppet/services/cinder-hpelefthand-iscsi.yaml b/puppet/services/cinder-hpelefthand-iscsi.yaml
index f22a3aeb..ca7d2838 100644
--- a/puppet/services/cinder-hpelefthand-iscsi.yaml
+++ b/puppet/services/cinder-hpelefthand-iscsi.yaml
@@ -1,4 +1,4 @@
-heat_template_version: 2017-02-24
+heat_template_version: ocata
description: >
Configure Cinder HPELeftHandISCSIDriver
diff --git a/tools/yaml-validate.py b/tools/yaml-validate.py
index f2359af6..63e3ce51 100755
--- a/tools/yaml-validate.py
+++ b/tools/yaml-validate.py
@@ -94,6 +94,10 @@ def validate_mysql_connection(settings):
def validate_service(filename, tpl):
+ if 'heat_template_version' in tpl and not str(tpl['heat_template_version']).isalpha():
+ print('ERROR: heat_template_version needs to be the release alias not a date: %s'
+ % filename)
+ return 1
if 'outputs' in tpl and 'role_data' in tpl['outputs']:
if 'value' not in tpl['outputs']['role_data']:
print('ERROR: invalid role_data for filename: %s'