From 1c725dd46f37e2b21d5e1dece467e4f5567bd761 Mon Sep 17 00:00:00 2001 From: Alex Schultz Date: Wed, 21 Sep 2016 15:21:49 -0600 Subject: Add aodh profile rspec testing This change adds rspec testing for the aodh profile and serves as an example as to how to add in spec testing using hieradata to provide some required parameters. This testing adds improved coverage for expectations around computed configuration items as well as for conditions around the steps within the tripleo deployment Change-Id: Ic763a544289a222fea97020a98821c1e375651a3 --- spec/classes/tripleo_profile_base_aodh_api_spec.rb | 74 +++++++++++++++++ .../tripleo_profile_base_aodh_evaluator_spec.rb | 59 ++++++++++++++ .../tripleo_profile_base_aodh_listener_spec.rb | 56 +++++++++++++ .../tripleo_profile_base_aodh_notifier_spec.rb | 56 +++++++++++++ spec/classes/tripleo_profile_base_aodh_spec.rb | 94 ++++++++++++++++++++++ spec/fixtures/hiera.yaml | 2 +- spec/fixtures/hieradata/default.yaml | 7 ++ spec/spec_helper.rb | 2 + 8 files changed, 349 insertions(+), 1 deletion(-) create mode 100644 spec/classes/tripleo_profile_base_aodh_api_spec.rb create mode 100644 spec/classes/tripleo_profile_base_aodh_evaluator_spec.rb create mode 100644 spec/classes/tripleo_profile_base_aodh_listener_spec.rb create mode 100644 spec/classes/tripleo_profile_base_aodh_notifier_spec.rb create mode 100644 spec/classes/tripleo_profile_base_aodh_spec.rb (limited to 'spec') diff --git a/spec/classes/tripleo_profile_base_aodh_api_spec.rb b/spec/classes/tripleo_profile_base_aodh_api_spec.rb new file mode 100644 index 0000000..d1f0b6b --- /dev/null +++ b/spec/classes/tripleo_profile_base_aodh_api_spec.rb @@ -0,0 +1,74 @@ +# +# Copyright (C) 2016 Red Hat, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + +require 'spec_helper' + +describe 'tripleo::profile::base::aodh::api' do + shared_examples_for 'tripleo::profile::base::aodh::api' do + let(:pre_condition) do + "class { '::tripleo::profile::base::aodh': step => #{params[:step]}, rabbit_hosts => ['127.0.0.1'] }" + end + + context 'with step less than 4' do + let(:params) { { :step => 3 } } + + it 'should do nothing' do + is_expected.to contain_class('tripleo::profile::base::aodh::api') + is_expected.to contain_class('tripleo::profile::base::aodh') + is_expected.to_not contain_class('aodh::api') + is_expected.to_not contain_class('aodh::wsgi::apache') + is_expected.to_not contain_aodh_config('api/enable_combination_alarms') + end + end + + context 'with step 4' do + let(:params) { { + :step => 4, + } } + + it 'should trigger complete configuration' do + is_expected.to contain_class('aodh::api') + is_expected.to contain_class('aodh::wsgi::apache') + is_expected.to contain_aodh_config('api/enable_combination_alarms').with_value('false') + end + end + + context 'with step 4 and enable combo alarms' do + let(:params) { { + :step => 4, + :enable_combination_alarms => true + } } + + it 'should trigger complete configuration' do + is_expected.to contain_class('aodh::api') + is_expected.to contain_class('aodh::wsgi::apache') + is_expected.to contain_aodh_config('api/enable_combination_alarms').with_value('true') + end + end + + end + + + on_supported_os.each do |os, facts| + context "on #{os}" do + let(:facts) do + facts.merge({ :hostname => 'node.example.com' }) + end + + it_behaves_like 'tripleo::profile::base::aodh::api' + end + end +end diff --git a/spec/classes/tripleo_profile_base_aodh_evaluator_spec.rb b/spec/classes/tripleo_profile_base_aodh_evaluator_spec.rb new file mode 100644 index 0000000..5ac7971 --- /dev/null +++ b/spec/classes/tripleo_profile_base_aodh_evaluator_spec.rb @@ -0,0 +1,59 @@ +# +# Copyright (C) 2016 Red Hat, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + +require 'spec_helper' + +describe 'tripleo::profile::base::aodh::evaluator' do + shared_examples_for 'tripleo::profile::base::aodh::evaluator' do + let(:pre_condition) do + "class { '::tripleo::profile::base::aodh': step => #{params[:step]}, rabbit_hosts => ['127.0.0.1'] }" + end + + context 'with step less than 4' do + let(:params) { { :step => 3 } } + + it 'should do nothing' do + is_expected.to contain_class('tripleo::profile::base::aodh::evaluator') + is_expected.to contain_class('tripleo::profile::base::aodh') + is_expected.to_not contain_class('aodh::evaluator') + end + end + + context 'with step 4' do + let(:params) { { + :step => 4, + } } + + it 'should trigger complete configuration' do + # TODO(aschultz): need to parameterize the pass/vip so we can test ipv6 + is_expected.to contain_class('aodh::evaluator').with( + :coordination_url => 'redis://:password@127.0.0.1:6379/' + ) + end + end + end + + + on_supported_os.each do |os, facts| + context "on #{os}" do + let(:facts) do + facts.merge({ :hostname => 'node.example.com' }) + end + + it_behaves_like 'tripleo::profile::base::aodh::evaluator' + end + end +end diff --git a/spec/classes/tripleo_profile_base_aodh_listener_spec.rb b/spec/classes/tripleo_profile_base_aodh_listener_spec.rb new file mode 100644 index 0000000..da1305f --- /dev/null +++ b/spec/classes/tripleo_profile_base_aodh_listener_spec.rb @@ -0,0 +1,56 @@ +# +# Copyright (C) 2016 Red Hat, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + +require 'spec_helper' + +describe 'tripleo::profile::base::aodh::listener' do + shared_examples_for 'tripleo::profile::base::aodh::listener' do + let(:pre_condition) do + "class { '::tripleo::profile::base::aodh': step => #{params[:step]}, rabbit_hosts => ['127.0.0.1'] }" + end + + context 'with step less than 4' do + let(:params) { { :step => 3 } } + + it 'should do nothing' do + is_expected.to contain_class('tripleo::profile::base::aodh::listener') + is_expected.to contain_class('tripleo::profile::base::aodh') + is_expected.to_not contain_class('aodh::listener') + end + end + + context 'with step 4' do + let(:params) { { + :step => 4, + } } + + it 'should trigger complete configuration' do + is_expected.to contain_class('aodh::listener') + end + end + end + + + on_supported_os.each do |os, facts| + context "on #{os}" do + let(:facts) do + facts.merge({ :hostname => 'node.example.com' }) + end + + it_behaves_like 'tripleo::profile::base::aodh::listener' + end + end +end diff --git a/spec/classes/tripleo_profile_base_aodh_notifier_spec.rb b/spec/classes/tripleo_profile_base_aodh_notifier_spec.rb new file mode 100644 index 0000000..1b74a68 --- /dev/null +++ b/spec/classes/tripleo_profile_base_aodh_notifier_spec.rb @@ -0,0 +1,56 @@ +# +# Copyright (C) 2016 Red Hat, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + +require 'spec_helper' + +describe 'tripleo::profile::base::aodh::notifier' do + shared_examples_for 'tripleo::profile::base::aodh::notifier' do + let(:pre_condition) do + "class { '::tripleo::profile::base::aodh': step => #{params[:step]}, rabbit_hosts => ['127.0.0.1'] }" + end + + context 'with step less than 4' do + let(:params) { { :step => 3 } } + + it 'should do nothing' do + is_expected.to contain_class('tripleo::profile::base::aodh::notifier') + is_expected.to contain_class('tripleo::profile::base::aodh') + is_expected.to_not contain_class('aodh::notifier') + end + end + + context 'with step 4' do + let(:params) { { + :step => 4, + } } + + it 'should trigger complete configuration' do + is_expected.to contain_class('aodh::notifier') + end + end + end + + + on_supported_os.each do |os, facts| + context "on #{os}" do + let(:facts) do + facts.merge({ :hostname => 'node.example.com' }) + end + + it_behaves_like 'tripleo::profile::base::aodh::notifier' + end + end +end diff --git a/spec/classes/tripleo_profile_base_aodh_spec.rb b/spec/classes/tripleo_profile_base_aodh_spec.rb new file mode 100644 index 0000000..10c17eb --- /dev/null +++ b/spec/classes/tripleo_profile_base_aodh_spec.rb @@ -0,0 +1,94 @@ +# +# Copyright (C) 2016 Red Hat, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + +require 'spec_helper' + +describe 'tripleo::profile::base::aodh' do + shared_examples_for 'tripleo::profile::base::aodh' do + context 'with step less than 3' do + let(:params) { { :step => 1 } } + it 'should do nothing' do + is_expected.to contain_class('tripleo::profile::base::aodh') + is_expected.to_not contain_class('aodh') + is_expected.to_not contain_class('aodh::auth') + is_expected.to_not contain_class('aodh::config') + is_expected.to_not contain_class('aodh::client') + is_expected.to_not contain_class('aodh::db::sync') + end + end + + context 'with step 3 on bootstrap node' do + let(:params) { { + :step => 3, + :bootstrap_node => 'node.example.com', + :rabbit_hosts => ['127.0.0.1', '127.0.0.2'] + } } + + it 'should trigger complete configuration' do + is_expected.to contain_class('aodh').with( + :rabbit_hosts => params[:rabbit_hosts] + ) + is_expected.to contain_class('aodh::auth') + is_expected.to contain_class('aodh::config') + is_expected.to contain_class('aodh::client') + is_expected.to contain_class('aodh::db::sync') + end + end + + context 'with step 3 not on bootstrap node' do + let(:params) { { + :step => 3, + :bootstrap_node => 'soemthingelse.example.com' + } } + + it 'should not trigger any configuration' do + is_expected.to_not contain_class('aodh') + is_expected.to_not contain_class('aodh::auth') + is_expected.to_not contain_class('aodh::config') + is_expected.to_not contain_class('aodh::client') + is_expected.to_not contain_class('aodh::db::sync') + end + end + + context 'with step 4 on other node' do + let(:params) { { + :step => 4, + :bootstrap_node => 'somethingelse.example.com', + :rabbit_hosts => ['127.0.0.1', '127.0.0.2'] + } } + + it 'should trigger aodh configuration without mysql grant' do + is_expected.to contain_class('aodh').with( + :rabbit_hosts => params[:rabbit_hosts] + ) + is_expected.to contain_class('aodh::auth') + is_expected.to contain_class('aodh::config') + is_expected.to contain_class('aodh::client') + is_expected.to contain_class('aodh::db::sync') + end + end + end + + on_supported_os.each do |os, facts| + context "on #{os}" do + let(:facts) do + facts.merge({ :hostname => 'node.example.com' }) + end + + it_behaves_like 'tripleo::profile::base::aodh' + end + end +end diff --git a/spec/fixtures/hiera.yaml b/spec/fixtures/hiera.yaml index 1dc3360..d5368e9 100644 --- a/spec/fixtures/hiera.yaml +++ b/spec/fixtures/hiera.yaml @@ -4,4 +4,4 @@ :yaml: :datadir: './spec/fixtures/hieradata' :hierarchy: - - default + - 'default' diff --git a/spec/fixtures/hieradata/default.yaml b/spec/fixtures/hieradata/default.yaml index 0d0c944..7a57a15 100644 --- a/spec/fixtures/hieradata/default.yaml +++ b/spec/fixtures/hieradata/default.yaml @@ -1,3 +1,10 @@ +--- my_hash: network: '127.0.0.1' not_hash: string +# aodh profile required hieradata +aodh_redis_password: 'password' +redis_vip: '127.0.0.1' +aodh::auth::auth_password: 'password' +aodh::db::mysql::password: 'password' +aodh::keystone::authtoken::password: 'password' diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index b06b436..4fa8cc3 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -19,6 +19,8 @@ RSpec.configure do |c| # custom global facts for all rspec tests add_custom_fact :concat_basedir, '/var/lib/puppet/concat' + # needed for testing Puppet Openstack modules + add_custom_fact :os_service_default, '' end at_exit { RSpec::Puppet::Coverage.report! } -- cgit 1.2.3-korg