From fb10b8ec5be95e761d541162150ca3eec7b58a61 Mon Sep 17 00:00:00 2001
From: Oliver Walsh <owalsh@redhat.com>
Date: Mon, 10 Jul 2017 15:48:22 +0100
Subject: Refactor iscsi initiator-name reset into separate profile

This currently assumes nova-compute and iscsid run in the same context which
isn't true for a containerized deployment

Change-Id: I91f1ce7625c351745dbadd84b565d55598ea5b59
---
 manifests/profile/base/iscsid.pp       | 45 ++++++++++++++++++++++++++++++++++
 manifests/profile/base/nova/compute.pp | 13 ----------
 2 files changed, 45 insertions(+), 13 deletions(-)
 create mode 100644 manifests/profile/base/iscsid.pp

(limited to 'manifests/profile/base')

diff --git a/manifests/profile/base/iscsid.pp b/manifests/profile/base/iscsid.pp
new file mode 100644
index 0000000..3637097
--- /dev/null
+++ b/manifests/profile/base/iscsid.pp
@@ -0,0 +1,45 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+# == Class: tripleo::profile::base::iscsid
+#
+# Nova Compute profile for tripleo
+#
+# === Parameters
+#
+# [*step*]
+#   (Optional) The current step in deployment. See tripleo-heat-templates
+#   for more details.
+#   Defaults to hiera('step')
+#
+class tripleo::profile::base::iscsid (
+  $step               = Integer(hiera('step')),
+) {
+
+  if $step >= 2 {
+    # When utilising images for deployment, we need to reset the iSCSI initiator name to make it unique
+    # https://bugzilla.redhat.com/show_bug.cgi?id=1244328
+    ensure_resource('package', 'iscsi-initiator-utils', { ensure => 'present' })
+    exec { 'reset-iscsi-initiator-name':
+      command => '/bin/echo InitiatorName=$(/usr/sbin/iscsi-iname) > /etc/iscsi/initiatorname.iscsi',
+      onlyif  => '/usr/bin/test ! -f /etc/iscsi/.initiator_reset',
+      before  => File['/etc/iscsi/.initiator_reset'],
+      require => Package['iscsi-initiator-utils'],
+      tag     => 'iscsid_config'
+    }
+    file { '/etc/iscsi/.initiator_reset':
+      ensure => present,
+    }
+  }
+}
diff --git a/manifests/profile/base/nova/compute.pp b/manifests/profile/base/nova/compute.pp
index bd50204..3eae880 100644
--- a/manifests/profile/base/nova/compute.pp
+++ b/manifests/profile/base/nova/compute.pp
@@ -45,19 +45,6 @@ class tripleo::profile::base::nova::compute (
 
     # deploy bits to connect nova compute to neutron
     include ::nova::network::neutron
-
-    # When utilising images for deployment, we need to reset the iSCSI initiator name to make it unique
-    # https://bugzilla.redhat.com/show_bug.cgi?id=1244328
-    ensure_resource('package', 'iscsi-initiator-utils', { ensure => 'present' })
-    exec { 'reset-iscsi-initiator-name':
-      command => '/bin/echo InitiatorName=$(/usr/sbin/iscsi-iname) > /etc/iscsi/initiatorname.iscsi',
-      onlyif  => '/usr/bin/test ! -f /etc/iscsi/.initiator_reset',
-      before  => File['/etc/iscsi/.initiator_reset'],
-      require => Package['iscsi-initiator-utils'],
-    }
-    file { '/etc/iscsi/.initiator_reset':
-      ensure => present,
-    }
   }
 
   # If NFS is used as a Cinder backend
-- 
cgit 1.2.3-korg