From b11d048e55fc20a90bcf11eed0f4cea5e1b45f7c Mon Sep 17 00:00:00 2001 From: Sofer Athlan-Guyot Date: Tue, 8 Nov 2016 10:16:53 +0100 Subject: Better way to ensure keepalived before haproxy. The lastest patchset of https://review.openstack.org/393361 was actually not working. The `if defined` idiom depends on *evaluation* order. At the time it's red in the haproxy.pp class, the line that loads the class 'haproxy' has still not yet been reached and thus the `defined` result is false. The constraint is not added. For this reason, the use of `defined` in module is not advised by puppetlabs[1]. [1] https://docs.puppet.com/puppet/latest/reference/function.html#defined Change-Id: Ibd352cb313f8863d62db8987419378bed5b87256 Relates-To: #1638029 --- manifests/keepalived.pp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'manifests/keepalived.pp') diff --git a/manifests/keepalived.pp b/manifests/keepalived.pp index 515dcd0..0e9262d 100644 --- a/manifests/keepalived.pp +++ b/manifests/keepalived.pp @@ -158,8 +158,4 @@ class tripleo::keepalived ( priority => 101, } } - # Make sure keepalive starts before haproxy. - if (defined(Class['::haproxy'])) { - Class['::keepalived::service'] -> Class['::haproxy'] - } } -- cgit 1.2.3-korg