From 5702f5b5e0721d9af61e494691376f32652e0048 Mon Sep 17 00:00:00 2001 From: Ross Brattain Date: Thu, 11 Jan 2018 11:09:45 -0800 Subject: pylint: make Jenkins output parseable Jenkins doesn't handle the color and the output is hard to read in Jenkins logs Change-Id: Ie8fc5a78e89f72c829e4bbbcbd1291a723dfde72 Signed-off-by: Ross Brattain --- tools/coding-checks.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/coding-checks.sh b/tools/coding-checks.sh index 4ee909988..6a12a1e99 100644 --- a/tools/coding-checks.sh +++ b/tools/coding-checks.sh @@ -28,6 +28,7 @@ process_options () { run_pylint () { local target="${scriptargs:-all}" + local output_format="" if [ "$target" = "all" ]; then files="ansible api tests yardstick" @@ -37,11 +38,15 @@ run_pylint () { *) echo "$target is an unrecognized basecommit"; exit 1;; esac fi - + # make Jenkins output parseable because Jenkins doesn't handle color + # enventually we should use the Jenkins Pylint plugin or other tools + if [ -n "${JENKINS_HOME:-}" ] ; then + output_format="--output-format=parseable" + fi echo "Running pylint..." echo "You can speed this up by running it on 'HEAD~[0-9]' (e.g. HEAD~0, this change only)..." if [ -n "${files}" ]; then - pylint --rcfile=.pylintrc ${files} + pylint --rcfile=.pylintrc ${output_format} ${files} else echo "No python changes in this commit, pylint check not required." exit 0 -- cgit 1.2.3-korg