From 277b3bf54e7496bf48a489a238795419a0d7051c Mon Sep 17 00:00:00 2001 From: "ahmed.helmy" Date: Thu, 14 Dec 2017 16:17:51 +0200 Subject: imporve the dev documentation Change-Id: Iee39de822490b26ee8d39e0a1b7a105a7bc16b4d Signed-off-by: ahmed.helmy --- moonv4/DEV.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/moonv4/DEV.md b/moonv4/DEV.md index f9864639..0dff2f17 100644 --- a/moonv4/DEV.md +++ b/moonv4/DEV.md @@ -27,6 +27,7 @@ - `git remote add gerrit ssh://@gerrit.opnfv.org:29418/moon.git` - add the ssh public key to the Gerrit web - `git review –s`: test the Gerrit review connection +- add Contributor Agreement, from settings/Agreement ### Gerrit-Review - git add XXX @@ -34,11 +35,12 @@ - git review ### Review Correction -- `git clone https://git.openstack.org/openstack/oslo-specs` -- `cd oslo-specs` -- `git fetch https://git.openstack.org/openstack/oslo-specs refs/changes/43/492543/1 && git checkout FETCH_HEAD` -- `git checkout -b 492543-1` -- `vi specs/policy/external-pdp.rst` +- `git clone https://git.opnfv.org/moon` +- `cd moon` +- get the commit id from Gerrit dashboard +- `git checkout commit_id` +- `git checkout -b 48957-1` (where '48957' is the change number and '1' is the patch_number) +- do your changes ex:`vi specs/policy/external-pdp.rst` - `git add specs/policy/external-pdp.rst` - `git commit –amend` - `git review` -- cgit 1.2.3-korg